Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org,
	Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 1/2] box: export mpstream methods to core
Date: Tue, 28 Aug 2018 09:46:19 +0300	[thread overview]
Message-ID: <1235e702-db1d-8a37-e1b3-b4817edadb26@tarantool.org> (raw)
In-Reply-To: <53a9fff6-61ff-cffc-6f9d-073cd38d6928@tarantool.org>

Hi. Thank you for comments.
> 1. As I said in the previous review, reserve and
> reserve_slow are not split in two functions just
> for case. There is a reason. And your patch
> destroys the benefit of reserve/reserve_slow
> splitting. I paste it here:
Sorry for misunderstanding, I didn't catch this words. Only why does mpstream is a header-only library.
-void
-mpstream_flush(struct mpstream *stream);
+static inline void
+mpstream_flush(struct mpstream *stream)

-char *
-mpstream_reserve(struct mpstream *stream, size_t size);
+static inline char *
+mpstream_reserve(struct mpstream *stream, size_t size)

-void
-mpstream_advance(struct mpstream *stream, size_t size);
+static inline void
+mpstream_advance(struct mpstream *stream, size_t size)


> 2. It is not 'LUA' anymore.
Ok, fixed-#ifndef TARANTOOL_LUA_MPSTREAM_H_INCLUDED
-#define TARANTOOL_LUA_MPSTREAM_H_INCLUDED
+#ifndef TARANTOOL_MPSTREAM_H_INCLUDED
+#define TARANTOOL_MPSTREAM_H_INCLUDED

  reply	other threads:[~2018-08-28  6:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27 11:11 [tarantool-patches] [PATCH v2 0/2] sql: remove struct Enc Kirill Shcherbatov
2018-08-27 11:11 ` [tarantool-patches] [PATCH v2 1/2] box: export mpstream methods to core Kirill Shcherbatov
2018-08-28  1:43   ` [tarantool-patches] " Vladislav Shpilevoy
2018-08-28  6:46     ` Kirill Shcherbatov [this message]
2018-08-27 11:11 ` [tarantool-patches] [PATCH v2 2/2] sql: remove struct Enc Kirill Shcherbatov
2018-08-28  1:43   ` [tarantool-patches] " Vladislav Shpilevoy
2018-08-28  6:46     ` Kirill Shcherbatov
2018-08-28 23:21       ` Vladislav Shpilevoy
2018-08-28  1:43 ` [tarantool-patches] Re: [PATCH v2 0/2] " Vladislav Shpilevoy
2018-08-29 14:12 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1235e702-db1d-8a37-e1b3-b4817edadb26@tarantool.org \
    --to=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH v2 1/2] box: export mpstream methods to core' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox