From: Oleg Babin <olegrok@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Oleg Babin <babinoleg@mail.ru>, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3] error: add __concat method to error object
Date: Wed, 15 Jan 2020 15:35:42 +0300 [thread overview]
Message-ID: <11e9b97a-3f3a-b3b0-5276-6e51468552da@tarantool.org> (raw)
In-Reply-To: <20200115112639.4rlwuxssjcshj65c@tkn_work_nb>
Thanks!
I've changed commit message and force pushed it to the top of my branch:
https://github.com/tarantool/tarantool/tree/olegrok/4489-concat-for-errors
New commit message:
commit a9ad4bdfa51174223e0d10ef0b6a751fd15a6d8e (HEAD ->
olegrok/4489-concat-for-errors, origin/olegrok/4489-concat-for-errors)
Author: Oleg Babin <babinoleg@mail.ru>
Date: Fri Jan 10 18:35:03 2020 +0300
error: add __concat method to error object
Usually functions return pair `nil, err` and expected that err is
string.
Let's make the behaviour of error object closer to string
and define __concat metamethod.
The case of error "error_mt.__concat(): neither of args is an error"
is not covered by tests because of #4723
Closes #4489
On 15/01/2020 14:26, Alexander Turenko wrote:
> LGTM.
>
> Just two minor comments re commit message.
>
---
Oleg Babin
next prev parent reply other threads:[~2020-01-15 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 15:48 olegrok
2020-01-14 14:21 ` Sergey Ostanevich
2020-01-14 15:02 ` Oleg Babin
2020-01-15 11:26 ` Alexander Turenko
2020-01-15 12:35 ` Oleg Babin [this message]
2020-01-16 22:02 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11e9b97a-3f3a-b3b0-5276-6e51468552da@tarantool.org \
--to=olegrok@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=babinoleg@mail.ru \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3] error: add __concat method to error object' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox