* [Tarantool-patches] [PATCH 1/1] build: link bit library to vclock library
@ 2020-05-26 21:57 Vladislav Shpilevoy
2020-05-27 10:42 ` Timur Safin
2020-05-27 22:02 ` Vladislav Shpilevoy
0 siblings, 2 replies; 3+ messages in thread
From: Vladislav Shpilevoy @ 2020-05-26 21:57 UTC (permalink / raw)
To: tarantool-patches, tsafin
Vclock depends on bit library, but wasn't linked to it.
---
Branch: http://github.com/tarantool/tarantool/tree/gerold103/add-missing-lib
src/box/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/box/CMakeLists.txt b/src/box/CMakeLists.txt
index 7dc94d893..230e7427d 100644
--- a/src/box/CMakeLists.txt
+++ b/src/box/CMakeLists.txt
@@ -34,7 +34,7 @@ include_directories(${ZSTD_INCLUDE_DIRS})
include_directories(${CMAKE_BINARY_DIR}/src/box/sql)
add_library(vclock STATIC vclock.c)
-target_link_libraries(vclock core)
+target_link_libraries(vclock core bit)
add_library(box_error STATIC error.cc errcode.c mp_error.cc)
target_link_libraries(box_error core stat mpstream vclock)
--
2.21.1 (Apple Git-122.3)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Tarantool-patches] [PATCH 1/1] build: link bit library to vclock library
2020-05-26 21:57 [Tarantool-patches] [PATCH 1/1] build: link bit library to vclock library Vladislav Shpilevoy
@ 2020-05-27 10:42 ` Timur Safin
2020-05-27 22:02 ` Vladislav Shpilevoy
1 sibling, 0 replies; 3+ messages in thread
From: Timur Safin @ 2020-05-27 10:42 UTC (permalink / raw)
To: 'Vladislav Shpilevoy', tarantool-patches
LGTM as trivial
: -----Original Message-----
: From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
: Sent: Wednesday, May 27, 2020 12:58 AM
: To: tarantool-patches@dev.tarantool.org; tsafin@tarantool.org
: Subject: [PATCH 1/1] build: link bit library to vclock library
:
: Vclock depends on bit library, but wasn't linked to it.
: ---
: Branch: http://github.com/tarantool/tarantool/tree/gerold103/add-missing-
: lib
:
: src/box/CMakeLists.txt | 2 +-
: 1 file changed, 1 insertion(+), 1 deletion(-)
:
: diff --git a/src/box/CMakeLists.txt b/src/box/CMakeLists.txt
: index 7dc94d893..230e7427d 100644
: --- a/src/box/CMakeLists.txt
: +++ b/src/box/CMakeLists.txt
: @@ -34,7 +34,7 @@ include_directories(${ZSTD_INCLUDE_DIRS})
: include_directories(${CMAKE_BINARY_DIR}/src/box/sql)
:
: add_library(vclock STATIC vclock.c)
: -target_link_libraries(vclock core)
: +target_link_libraries(vclock core bit)
:
: add_library(box_error STATIC error.cc errcode.c mp_error.cc)
: target_link_libraries(box_error core stat mpstream vclock)
: --
: 2.21.1 (Apple Git-122.3)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Tarantool-patches] [PATCH 1/1] build: link bit library to vclock library
2020-05-26 21:57 [Tarantool-patches] [PATCH 1/1] build: link bit library to vclock library Vladislav Shpilevoy
2020-05-27 10:42 ` Timur Safin
@ 2020-05-27 22:02 ` Vladislav Shpilevoy
1 sibling, 0 replies; 3+ messages in thread
From: Vladislav Shpilevoy @ 2020-05-27 22:02 UTC (permalink / raw)
To: tarantool-patches, tsafin
Pushed to master.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-27 22:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-26 21:57 [Tarantool-patches] [PATCH 1/1] build: link bit library to vclock library Vladislav Shpilevoy
2020-05-27 10:42 ` Timur Safin
2020-05-27 22:02 ` Vladislav Shpilevoy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox