From: "Timur Safin" <tsafin@tarantool.org>
To: 'Vladislav Shpilevoy' <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] build: link bit library to vclock library
Date: Wed, 27 May 2020 13:42:45 +0300 [thread overview]
Message-ID: <11c201d63413$8ec95330$ac5bf990$@tarantool.org> (raw)
In-Reply-To: <6183280820543b8fa5f8dba7d934be5f2e97148b.1590530239.git.v.shpilevoy@tarantool.org>
LGTM as trivial
: -----Original Message-----
: From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
: Sent: Wednesday, May 27, 2020 12:58 AM
: To: tarantool-patches@dev.tarantool.org; tsafin@tarantool.org
: Subject: [PATCH 1/1] build: link bit library to vclock library
:
: Vclock depends on bit library, but wasn't linked to it.
: ---
: Branch: http://github.com/tarantool/tarantool/tree/gerold103/add-missing-
: lib
:
: src/box/CMakeLists.txt | 2 +-
: 1 file changed, 1 insertion(+), 1 deletion(-)
:
: diff --git a/src/box/CMakeLists.txt b/src/box/CMakeLists.txt
: index 7dc94d893..230e7427d 100644
: --- a/src/box/CMakeLists.txt
: +++ b/src/box/CMakeLists.txt
: @@ -34,7 +34,7 @@ include_directories(${ZSTD_INCLUDE_DIRS})
: include_directories(${CMAKE_BINARY_DIR}/src/box/sql)
:
: add_library(vclock STATIC vclock.c)
: -target_link_libraries(vclock core)
: +target_link_libraries(vclock core bit)
:
: add_library(box_error STATIC error.cc errcode.c mp_error.cc)
: target_link_libraries(box_error core stat mpstream vclock)
: --
: 2.21.1 (Apple Git-122.3)
next prev parent reply other threads:[~2020-05-27 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 21:57 Vladislav Shpilevoy
2020-05-27 10:42 ` Timur Safin [this message]
2020-05-27 22:02 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='11c201d63413$8ec95330$ac5bf990$@tarantool.org' \
--to=tsafin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] build: link bit library to vclock library' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox