Tarantool development patches archive
 help / color / mirror / Atom feed
From: roman.habibov1@yandex.ru
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
	"tarantool-patches@freelists.org"
	<tarantool-patches@freelists.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE
Date: Mon, 07 May 2018 21:50:11 +0300	[thread overview]
Message-ID: <1154681525719011@web34j.yandex.ru> (raw)
In-Reply-To: <399639c2-dcd6-da4b-8402-f0ec10f3ea74@tarantool.org>

diff --git a/commits/1 b/commits/1
index 27ef2f6..dee20d6 100644

@@ -5,7 +5,7 @@ Date: Sat, 5 May 2018 01:45:06 +0300
 Subject: [PATCH v1 1/1] sql: tests for CREATE TEMP TABLE and  CREATE TEMPORARY
  TABLE

07.05.2018, 16:08, "Vladislav Shpilevoy" <v.shpilevoy@tarantool.org>:
> 1. Please, in the commit title write a Tarantool submodule prefix. For example,
> your patch is about SQL, so you would write 'sql: ' prefix.

diff --git a/test/sql-tap/table.test.lua b/test/sql-tap/table.test.lua
index 4882b18..21213bc 100755
--- a/test/sql-tap/table.test.lua
+++ b/test/sql-tap/table.test.lua
@@ -611,6 +611,9 @@ test:do_execsql2_test(
 --     SELECT * FROM [t4"abc];
 --   }
 -- } {cnt 1 max(b+c) 5}
+
+-- gh-2166 functions with TEMP and TEMPORARY are removed, tests needed to show that
+
 test:do_catchsql_test(
 	"temp",
 	[[

07.05.2018, 16:08, "Vladislav Shpilevoy" <v.shpilevoy@tarantool.org>:
>2. Before the test cases write in comments what do you test here, and
>:write a link to the issue in the format 'gh-NNNN: description'.

  reply	other threads:[~2018-05-07 18:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-05 22:34 [tarantool-patches] " Roman Khabibov
2018-05-07 13:08 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-07 18:50   ` roman.habibov1 [this message]
2018-05-07 23:12     ` Vladislav Shpilevoy
2018-05-07 23:30       ` roman.habibov1
2018-05-08  8:15         ` Vladislav Shpilevoy
2018-05-08 10:30 ` n.pettik
     [not found]   ` <2050311525824390@web59j.yandex.ru>
2018-05-09 14:30     ` [tarantool-patches] Re: [PATCH v1 1/1] sql: " n.pettik
2018-05-09 17:20       ` roman.habibov1
2018-05-11 13:12         ` n.pettik
2018-05-11 15:18           ` [tarantool-patches] Re: [PATCH v1 1/1] sql: added tests for TEMP and TEMPORARY clauses roman.habibov1
2018-05-14 14:50             ` n.pettik
2018-05-18 23:44               ` roman.habibov1
2018-05-19  0:28                 ` n.pettik
2018-05-19 11:57                   ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1154681525719011@web34j.yandex.ru \
    --to=roman.habibov1@yandex.ru \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH v1 1/1] Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox