[tarantool-patches] Re: [PATCH] sql: introduce ADD CONSTRAINT CHECK statement

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Hi! Thanks for the patch!

On 08/07/2019 20:57, Nikita Pettik wrote:
> This patch extends parser's grammar to allow to create CHECK constraints
> on already existent tables via SQL facilities. Syntax is following:
> 
> ALTER TABLE <table> ADD CONSTRAINT <name> CHECK (<expr>);
> 
> Closes #3097
> ---

TarantoolBot request?

> diff --git a/test/sql-tap/alter2.test.lua b/test/sql-tap/alter2.test.lua
> index 8969dfab2..4dc8f8255 100755
> --- a/test/sql-tap/alter2.test.lua
> +++ b/test/sql-tap/alter2.test.lua
> @@ -1,6 +1,6 @@
>  #!/usr/bin/env tarantool
>  test = require("sqltester")
> -test:plan(21)
> +test:plan(26)
>  
>  -- This suite is aimed to test ALTER TABLE ADD CONSTRAINT statement.
>  --
> @@ -260,4 +260,50 @@ test:do_catchsql_test(
>          -- </alter2-5.2>
>      })
>  
> +-- Test ADD CONSTRAINT CHECK functionality. CHECK constraints are
> +-- intagrated into Tarantool's core, so basically we whould test

Typos. 'intagrated', 'whould'.