From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/1] swim: keep encoded round message cached
Date: Thu, 11 Apr 2019 20:22:13 +0300 [thread overview]
Message-ID: <1110c851-06ce-b2f8-3995-bea29b38c65f@tarantool.org> (raw)
In-Reply-To: <20190411162456.GB7446@chai>
Pushed to the master.
On 11/04/2019 19:24, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/04/11 19:13]:
>
> OK to push.
>
>>> Are you going to add anything to this method? If not, please get
>>> rid of it and inline swim_packet_create() to all relevant places,
>>> with an appropriate comment.
>>
>> I am not going to change it now, but
>>
>> 1) I (or anyone else) can change my (their) mind in future. Even
>> during SWIM development we already did it. I have this patch
>> since the SWIM implementation was multi-packet, and invalidation
>> of the cache was different.
>>
>> 2) This logic of recreating the packet is too internal to be
>> inlined in all the usage places. I would rather comment this
>> function and logic in one encapsulated place, and would just
>> call it.
>
> They can easily re-introduce this function when necessary.
>
> --
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
>
prev parent reply other threads:[~2019-04-11 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 10:55 [tarantool-patches] " Vladislav Shpilevoy
2019-04-10 11:00 ` [tarantool-patches] " Vladislav Shpilevoy
2019-04-11 13:51 ` Konstantin Osipov
2019-04-11 16:09 ` Vladislav Shpilevoy
2019-04-11 16:24 ` Konstantin Osipov
2019-04-11 17:22 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110c851-06ce-b2f8-3995-bea29b38c65f@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 1/1] swim: keep encoded round message cached' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox