From: "Timur Safin" <tsafin@tarantool.org> To: 'Chris Sosnin' <k.sosnin@tarantool.org>, v.shpilevoy@tarantool.org, korablev@tarantool.org, tarantool-patches@dev.tarantool.org, Kirill Yukhin <kyukhin@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 0/4] session settings fixes Date: Thu, 2 Apr 2020 12:14:35 +0300 [thread overview] Message-ID: <10e401d608cf$20ef8970$62ce9c50$@tarantool.org> (raw) In-Reply-To: <cover.1585559306.git.k.sosnin@tarantool.org> I'm late here on this party, but I very much dislike proposed syntax of SETTING SET configuration_name = value; It feels not SQL-ish, and I see no much value introducing new statement while there is still SET statement available. Why we could not simply use something like: SET box.session.settings.name = value; ? Thanks, Timur : -----Original Message----- : From: Tarantool-patches <tarantool-patches-bounces@dev.tarantool.org> On : Behalf Of Chris Sosnin : Sent: Monday, March 30, 2020 12:14 PM : To: v.shpilevoy@tarantool.org; korablev@tarantool.org; tarantool- : patches@dev.tarantool.org : Subject: [Tarantool-patches] [PATCH 0/4] session settings fixes : : issue #1:https://github.com/tarantool/tarantool/issues/4711 : issue #2:https://github.com/tarantool/tarantool/issues/4712 : branch:https://github.com/tarantool/tarantool/tree/ksosnin/gh-4712- : session-settings-v2 : : Chris Sosnin (4): : box: replace session_settings modules with a single array : box: add binary search for _session_settings space : box: provide a user friendly frontend for accessing session settings : sql: provide a user friendly frontend for accessing session settings : : extra/mkkeywordhash.c | 1 + : src/box/lua/session.c | 111 +++++++++ : src/box/session.cc | 1 + : src/box/session.h | 2 + : src/box/session_settings.c | 214 +++++++++++------- : src/box/session_settings.h | 53 +++-- : src/box/sql.c | 5 - : src/box/sql/build.c | 104 ++++----- : src/box/sql/parse.y | 5 + : src/box/sql/sqlInt.h | 11 + : src/box/sql/vdbe.c | 50 ++++ : ...rontend.result => session_settings.result} | 147 ++++++++++-- : ...end.test.lua => session_settings.test.lua} | 61 ++++- : 13 files changed, 589 insertions(+), 176 deletions(-) : rename test/box/{gh-4511-access-settings-from-any-frontend.result => : session_settings.result} (71%) : rename test/box/{gh-4511-access-settings-from-any-frontend.test.lua => : session_settings.test.lua} (64%) : : -- : 2.21.1 (Apple Git-122.3)
next prev parent reply other threads:[~2020-04-02 9:14 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-30 9:13 Chris Sosnin 2020-03-30 9:13 ` [Tarantool-patches] [PATCH 1/4] box: replace session_settings modules with a single array Chris Sosnin 2020-04-03 13:32 ` Nikita Pettik 2020-03-30 9:13 ` [Tarantool-patches] [PATCH 2/4] box: add binary search for _session_settings space Chris Sosnin 2020-04-03 14:00 ` Nikita Pettik 2020-04-13 13:40 ` Kirill Yukhin 2020-03-30 9:13 ` [Tarantool-patches] [PATCH 3/4] box: provide a user friendly frontend for accessing session settings Chris Sosnin 2020-04-03 14:47 ` Nikita Pettik 2020-03-30 9:13 ` [Tarantool-patches] [PATCH 4/4] sql: " Chris Sosnin 2020-04-03 15:19 ` Nikita Pettik 2020-04-04 21:56 ` Vladislav Shpilevoy 2020-04-10 15:40 ` Chris Sosnin 2020-04-11 17:18 ` Vladislav Shpilevoy 2020-04-13 7:50 ` Timur Safin 2020-04-02 9:14 ` Timur Safin [this message] 2020-04-02 10:18 ` [Tarantool-patches] [PATCH 0/4] session settings fixes Chris Sosnin 2020-04-03 12:47 ` Nikita Pettik 2020-04-03 13:09 ` Nikita Pettik 2020-04-03 14:02 ` Chris Sosnin 2020-04-13 14:18 ` Kirill Yukhin 2020-04-03 17:09 Peter Gulutzan 2020-04-03 18:11 ` Timur Safin 2020-04-07 16:32 ` Chris Sosnin 2020-04-08 9:40 ` Timur Safin 2020-04-08 15:03 ` Peter Gulutzan 2020-04-08 14:36 ` Peter Gulutzan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='10e401d608cf$20ef8970$62ce9c50$@tarantool.org' \ --to=tsafin@tarantool.org \ --cc=k.sosnin@tarantool.org \ --cc=korablev@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 0/4] session settings fixes' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox