From: Roman Khabibov <roman.habibov@tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 2/3] box: make constraint operations transactional
Date: Tue, 24 Dec 2019 15:06:27 +0300 [thread overview]
Message-ID: <1081F1BD-5243-459F-AADF-B0037F6A6F55@tarantool.org> (raw)
In-Reply-To: <20191221205437.GA45@tarantool.org>
Hi!
> And I'm still not sure about memory allocation/deallocation is correct during
> constraint id creation/drop.
If you mean: “Why do you allocate memory for the name string and copy it, if
the same name is already stored in corresponding index_def/ck_def/fk_def
structure”, I’ll answer you the following. At first, I didn’t use the constraint
name copy and did’t allocate memory for it. I simply put pointer to the original
name stored in corresponding index_def/ck_def/fk_def structure. As a result, I had
broken nodes with thrash instead of payload (name) in the constraint hash table.
It was occurred, because this name was free somewhere before. To avoid such situations,
I decided to copy the constraint name.
next prev parent reply other threads:[~2019-12-24 12:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 18:34 [Tarantool-patches] [PATCH v2 0/2] Add constraint names hash table to space Roman Khabibov
2019-11-28 18:34 ` [Tarantool-patches] [PATCH v2 1/2] box: introduce constraint names hash table Roman Khabibov
2019-11-30 1:03 ` Vladislav Shpilevoy
2019-12-04 16:23 ` [Tarantool-patches] [PATCH v2 1/3] " Roman Khabibov
2019-12-07 16:34 ` Vladislav Shpilevoy
2019-12-10 12:48 ` Roman Khabibov
2019-11-28 18:34 ` [Tarantool-patches] [PATCH v2 2/2] sql: make constraint operations transactional Roman Khabibov
2019-11-29 7:38 ` Roman Khabibov
2019-11-30 1:03 ` Vladislav Shpilevoy
2019-12-04 16:23 ` [Tarantool-patches] [PATCH v2 2/3] " Roman Khabibov
2019-12-05 18:43 ` Roman Khabibov
2019-12-07 16:35 ` Vladislav Shpilevoy
2019-12-10 12:49 ` [Tarantool-patches] [PATCH v2 2/3] box: " Roman Khabibov
2019-12-15 22:26 ` Vladislav Shpilevoy
2019-12-17 15:03 ` Roman Khabibov
2019-12-28 0:18 ` Nikita Pettik
2019-12-28 11:07 ` Vladislav Shpilevoy
2019-12-29 0:07 ` Nikita Pettik
2019-12-29 15:51 ` Vladislav Shpilevoy
2019-12-29 22:28 ` Nikita Pettik
2019-12-29 22:35 ` Vladislav Shpilevoy
2019-12-30 11:12 ` Sergey Ostanevich
2019-12-30 12:05 ` Nikita Pettik
2019-12-21 20:54 ` Sergey Ostanevich
2019-12-22 14:59 ` Vladislav Shpilevoy
2019-12-24 12:06 ` Roman Khabibov [this message]
2019-11-30 1:03 ` [Tarantool-patches] [PATCH v2 0/2] Add constraint names hash table to space Vladislav Shpilevoy
2019-12-04 16:23 ` [Tarantool-patches] [PATCH v2 0/3] " Roman Khabibov
2019-12-07 16:34 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1081F1BD-5243-459F-AADF-B0037F6A6F55@tarantool.org \
--to=roman.habibov@tarantool.org \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 2/3] box: make constraint operations transactional' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox