Re: [Tarantool-patches] [PATCH v1.2] evio: workaround for wsl1 so_linger assertion

["Timur Safin" <tsafin@tarantool.org>]

: -----Original Message-----
: From: Cyrill Gorcunov <gorcunov@gmail.com>
: Sent: Thursday, March 19, 2020 1:52 PM
: To: Timur Safin <tsafin@tarantool.org>
: Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>; tarantool-
: patches@dev.tarantool.org; Cyrill Gorcunov <gorcunov@tarantool.org>
: Subject: Re: [Tarantool-patches] [PATCH v1.2] evio: workaround for wsl1
: so_linger assertion
: 
: On Thu, Mar 19, 2020 at 01:27:08PM +0300, Timur Safin wrote:
: > SO_LINGER makes no much sense for unix-sockets, and Microsoft WSL
: > is returning EINVAL if setsockopts called for SO_LINGER over unix
: > sockets:
: >
: >   [004] 2020-03-11 18:42:29.592 [29182] main/102/app sio.c:169 !>
: SystemError setsockopt(SO_LINGER), called on fd 16, aka
: >   [004] 2020-03-11 18:42:29.592 [29182] main/102/app F> can't initialize
: storage: setsockopt(SO_LINGER), called on fd 16,
: >   [004] 2020-03-11 18:42:29.592 [29182] main/102/app F> can't initialize
: storage: setsockopt(SO_LINGER), called on fd 16,
: >
: > And it's sort of correct here, but the problem is Linux is simply
: > silently ignoring it, which passes tests.
: >
: > After much debates we decided to work-around this case via CMAKE
: > define.
: >
: > NB! In a future (April/May 2020), when WSL2 with full Linux kernel
: > would be released we should disable this check.
: 
: Hardly. This will break backward compatibility. Or we will have
: to _require_ WSL2 to build tarantool.

I'll find the proper way to distinguish WSL1/WSL2 by then. No problem.