From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: tarantool-patches@dev.tarantool.org, skaplun@tarantool.org, sergeyb@tarantool.org Subject: [Tarantool-patches] [PATCH luajit 3/4] Revert "Update cur_L on exceptional path (arm)" Date: Thu, 28 Sep 2023 20:08:48 +0300 [thread overview] Message-ID: <0ef2a0778f296dcb4b815a875899c452607cd7f9.1695920642.git.m.kokryashkin@tarantool.org> (raw) In-Reply-To: <cover.1695920642.git.m.kokryashkin@tarantool.org> This reverts commit 5ccd25d740476a37d414733b5192d5be0ef06173. As was mentioned in tarantool/tarantool#6189, throwing an error not on the currently executed coroutine is a violation of the Lua/C API. This patch is a part of the patchset that supports this violation and is reverted because of it. Part of tarantool/tarantool#6323 --- src/vm_arm.dasc | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/vm_arm.dasc b/src/vm_arm.dasc index 767d31f9..7095e660 100644 --- a/src/vm_arm.dasc +++ b/src/vm_arm.dasc @@ -351,7 +351,6 @@ static void build_subroutines(BuildCtx *ctx) | mv_vmstate CARG4, CFUNC | ldr GL:CARG3, L->glref | str CARG4, GL:CARG3->vmstate - | str L, GL:CARG3->cur_L | b ->vm_leave_unw | |->vm_unwind_ff: // Unwind C stack, return from ff pcall. @@ -372,7 +371,6 @@ static void build_subroutines(BuildCtx *ctx) | mv_vmstate CARG2, INTERP | str CARG1, [BASE, #-4] // Prepend false to error message. | st_vmstate CARG2 - | str L, [DISPATCH, #DISPATCH_GL(cur_L)] | b ->vm_returnc | |->vm_unwind_ext: // Complete external unwind. -- 2.42.0
next prev parent reply other threads:[~2023-09-28 17:10 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-28 17:08 [Tarantool-patches] [PATCH luajit 0/4] Fix error-throwing on an incorrect coroutine Maxim Kokryashkin via Tarantool-patches 2023-09-28 17:08 ` [Tarantool-patches] [PATCH luajit 1/4] Revert "Fix cur_L tracking on exceptional path" Maxim Kokryashkin via Tarantool-patches 2023-09-28 17:08 ` [Tarantool-patches] [PATCH luajit 2/4] Revert "Update cur_L " Maxim Kokryashkin via Tarantool-patches 2023-09-28 17:08 ` Maxim Kokryashkin via Tarantool-patches [this message] 2023-09-28 17:08 ` [Tarantool-patches] [PATCH luajit 4/4] Restore cur_L for specific Lua/C API use case Maxim Kokryashkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0ef2a0778f296dcb4b815a875899c452607cd7f9.1695920642.git.m.kokryashkin@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 3/4] Revert "Update cur_L on exceptional path (arm)"' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox