From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 3/3] test: add replication/gh-5446-qsync-eval-quorum.test.lua
Date: Sun, 20 Dec 2020 18:01:02 +0100 [thread overview]
Message-ID: <0df4021b-b2b5-0157-e532-0845b0842e92@tarantool.org> (raw)
In-Reply-To: <20201218081416.GG14556@grain>
Thanks for the fixes!
> Took both notes from some existing example. Would the following be better?
Yes, thanks, it does not raise any questions now. Although
you could keep 's' variable to access the space methods shorter.
> ---
> diff --git a/test/replication/gh-5446-qsync-eval-quorum.test.lua b/test/replication/gh-5446-qsync-eval-quorum.test.lua
> index 2ecfa8c3e..9f731a488 100644
> --- a/test/replication/gh-5446-qsync-eval-quorum.test.lua
> +++ b/test/replication/gh-5446-qsync-eval-quorum.test.lua
> @@ -17,10 +17,8 @@ test_run:grep_log("default", match) ~= nil
>
> -- Create a sync space we will operate on
> _ = box.schema.space.create('sync', {is_sync = true, engine = engine})
> -s = box.space.sync
> -s:format({{name = 'id', type = 'unsigned'}, {name = 'value', type = 'unsigned'}})
> -_ = s:create_index('primary', {parts = {'id'}})
> -s:insert{1, 1}
> +_ = box.space.sync:create_index('pk')
> +box.space.sync:insert{1}
next prev parent reply other threads:[~2020-12-20 17:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 11:39 [Tarantool-patches] [PATCH v4 0/3] qsync: evaluate replication_synchro_quorum dynamically Cyrill Gorcunov
2020-12-14 11:39 ` [Tarantool-patches] [PATCH v4 1/3] cfg: add cfg_isnumber helper Cyrill Gorcunov
2020-12-14 11:39 ` [Tarantool-patches] [PATCH v4 2/3] cfg: support symbolic evaluation of replication_synchro_quorum Cyrill Gorcunov
2020-12-16 13:21 ` Serge Petrenko
2020-12-16 13:35 ` Cyrill Gorcunov
2020-12-17 23:17 ` Vladislav Shpilevoy
2020-12-18 7:25 ` Cyrill Gorcunov
2020-12-20 17:01 ` Vladislav Shpilevoy
2020-12-20 18:28 ` Cyrill Gorcunov
2020-12-21 17:48 ` Vladislav Shpilevoy
2020-12-21 17:49 ` Vladislav Shpilevoy
2020-12-21 20:02 ` Cyrill Gorcunov
2020-12-21 20:12 ` Cyrill Gorcunov
2020-12-14 11:39 ` [Tarantool-patches] [PATCH v4 3/3] test: add replication/gh-5446-qsync-eval-quorum.test.lua Cyrill Gorcunov
2020-12-16 13:25 ` Serge Petrenko
2020-12-17 23:18 ` Vladislav Shpilevoy
2020-12-18 8:14 ` Cyrill Gorcunov
2020-12-20 17:01 ` Vladislav Shpilevoy [this message]
2020-12-20 18:27 ` Cyrill Gorcunov
2020-12-21 16:05 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0df4021b-b2b5-0157-e532-0845b0842e92@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.perepelitsa@corp.mail.ru \
--subject='Re: [Tarantool-patches] [PATCH v4 3/3] test: add replication/gh-5446-qsync-eval-quorum.test.lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox