From: Leonid Vasiliev <lvasiliev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org, gorcunov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH 2/2] txn: remove TXN_IS_DONE check from txn_commit()
Date: Wed, 22 Jul 2020 18:28:55 +0300 [thread overview]
Message-ID: <0dc7ceb0-c88e-977c-5396-404f93503721@tarantool.org> (raw)
In-Reply-To: <9193c791b19ac495f831aba37a906bf87742a87d.1595371239.git.v.shpilevoy@tarantool.org>
Hi! Thank you for the patch.
LGTM.
> diff --git a/test/unit/suite.ini b/test/unit/suite.ini
> index d429c95e9..d16ba413b 100644
> --- a/test/unit/suite.ini
> +++ b/test/unit/suite.ini
> @@ -1,5 +1,6 @@
> [default]
> core = unittest
> description = unit tests
> +disabled = snap_quorum_delay.test
Discussed the test with Vlad. I will write my point of view in
https://github.com/tarantool/tarantool/issues/5193
> release_disabled = fiber_stack.test swim_errinj.test
> is_parallel = True
>
next prev parent reply other threads:[~2020-07-22 15:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 22:42 [Tarantool-patches] [PATCH 0/2] Make txn_commit() simpler Vladislav Shpilevoy
2020-07-21 22:42 ` [Tarantool-patches] [PATCH 1/2] txn_limbo: single function to confirm transactions Vladislav Shpilevoy
2020-07-22 15:19 ` Leonid Vasiliev
2020-07-21 22:42 ` [Tarantool-patches] [PATCH 2/2] txn: remove TXN_IS_DONE check from txn_commit() Vladislav Shpilevoy
2020-07-22 15:28 ` Leonid Vasiliev [this message]
2020-07-22 8:40 ` [Tarantool-patches] [PATCH 0/2] Make txn_commit() simpler Cyrill Gorcunov
2020-07-22 23:14 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dc7ceb0-c88e-977c-5396-404f93503721@tarantool.org \
--to=lvasiliev@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] txn: remove TXN_IS_DONE check from txn_commit()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox