From: Kirill Shcherbatov <kshcherbatov@tarantool.org> To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org> Subject: [tarantool-patches] Re: [PATCH v2 5/5] sql: do not use OP_Delete+OP_Insert for UPDATES Date: Sat, 29 Dec 2018 18:31:50 +0300 [thread overview] Message-ID: <0dc44aab-94b0-c57d-686f-442375d83155@tarantool.org> (raw) In-Reply-To: <92C91EEB-6934-40C4-96C2-46487F97A697@tarantool.org> >> +/** Callback to forward and error from mpstream methods. */ >> +static inline void >> +mpstream_encode_error(void *error_ctx) >> +{ >> + *(bool *)error_ctx = true; >> +} > > Is this artefact after previous patch? Ugum, it was already fixed on branch. >> +void >> +mpstream_encode_vdbe_mem(struct mpstream *stream, struct Mem *var); >> + > The same question. Here I did it consciously. This routine was just a helper in previous patch so may be static that likelly doesn't require function call by pointer. In this patch it became reusable so I have to define it's signature in header. But I've already moved this change to previous path to decrease changes. It doesn't really matter. > The rest is Ok now. > I didn’t carefully check test fixes tho, only looked through, since they > consist of monotonic changes, but I believe you did it :)
next prev parent reply other threads:[~2018-12-29 15:31 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-29 10:48 [tarantool-patches] [PATCH v2 0/5] " Kirill Shcherbatov 2018-12-29 10:48 ` [tarantool-patches] [PATCH v2 1/5] sql: clean-up vdbe_emit_constraint_checks Kirill Shcherbatov 2018-12-29 10:48 ` [tarantool-patches] [PATCH v2 2/5] sql: fix sql_vdbe_mem_alloc_region result memory Kirill Shcherbatov 2018-12-29 10:49 ` [tarantool-patches] [PATCH v2 3/5] sql: fix fkey exception for self-referenced table Kirill Shcherbatov 2018-12-29 13:26 ` [tarantool-patches] " n.pettik 2018-12-29 10:49 ` [tarantool-patches] [PATCH v2 4/5] sql: encode tuples with mpstream on Vdbe run Kirill Shcherbatov 2018-12-29 13:26 ` [tarantool-patches] " n.pettik 2018-12-29 15:28 ` Kirill Shcherbatov 2019-01-09 12:29 ` n.pettik 2018-12-29 10:49 ` [tarantool-patches] [PATCH v2 5/5] sql: do not use OP_Delete+OP_Insert for UPDATES Kirill Shcherbatov 2018-12-29 13:35 ` [tarantool-patches] " n.pettik 2018-12-29 15:31 ` Kirill Shcherbatov [this message] 2019-01-10 12:30 ` [tarantool-patches] Re: [PATCH v2 0/5] " Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0dc44aab-94b0-c57d-686f-442375d83155@tarantool.org \ --to=kshcherbatov@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v2 5/5] sql: do not use OP_Delete+OP_Insert for UPDATES' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox