Tarantool development patches archive
 help / color / mirror / Atom feed
From: Stanislav Zudin <szudin@tarantool.org>
To: tarantool-patches@freelists.org, "n.pettik" <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 0/9] sql: cleanup code from obsolete macros
Date: Fri, 7 Jun 2019 14:57:08 +0300	[thread overview]
Message-ID: <0d83bb70-a1cb-061e-7d7a-1090a5cee6d2@tarantool.org> (raw)
In-Reply-To: <08530D5F-C413-4E0E-8251-DC61DFD24BED@tarantool.org>



On 06.06.2019 21:22, n.pettik wrote:
> 
> 
>> On 29 May 2019, at 17:01, Stanislav Zudin <szudin@tarantool.org> wrote:
>>
>> The patch removes unused constants and macros
>> The 2nd version returns back the SQL_OMIT_AUTOMATIC_INDEX and
>> the code enabled by this macro.
>> Removes the remains of the multithreading from the VDBE's
>> sorting tools.
>> Enables output of number of scanned rows when EXPLAIN
>> keyword is used. Updates the affected tests.
> 
> Generally speaking, patch-set is OK since it provides
> straightforward refactoring. But I would whether squash
> all these patches or change their description and group
> by thematic topics (like sql: remove unused macros
> connected with memory management system).
> It’s up to you.
> 
> 

I've squashed commits and rebased.

      reply	other threads:[~2019-06-07 11:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 14:01 [tarantool-patches] " Stanislav Zudin
2019-05-29 14:01 ` [tarantool-patches] [PATCH v2 1/9] " Stanislav Zudin
2019-05-29 14:01 ` [tarantool-patches] [PATCH v2 2/9] Removes unused functions and commented many years ago code Stanislav Zudin
2019-05-29 14:01 ` [tarantool-patches] [PATCH v2 3/9] Removes unused functions Stanislav Zudin
2019-05-29 14:01 ` [tarantool-patches] [PATCH v2 4/9] Removes unused functions and macros Stanislav Zudin
2019-05-29 14:01 ` [tarantool-patches] [PATCH v2 5/9] Removes the following unused macros: SQL_ENABLE_MEMORY_MANAGEMENT SQL_ENABLE_UNKNOWN_SQL_FUNCTION SQL_SUBSTR_COMPATIBILITY SQL_ENABLE_STMT_SCANSTATUS Stanislav Zudin
2019-05-29 14:01 ` [tarantool-patches] [PATCH v2 6/9] sql: cleanup code from obsolete macros Stanislav Zudin
2019-05-29 14:01 ` [tarantool-patches] [PATCH v2 7/9] Removes unused constants Stanislav Zudin
2019-05-29 14:01 ` [tarantool-patches] [PATCH v2 8/9] Removes the following unused macros: SQL_PRINTF_PRECISION_LIMIT SQL_OMIT_COMPOUND_SELECT SQL_POWERSAFE_OVERWRITE SQL_OMIT_PROGRESS_CALLBACK SQL_OMIT_AUTORESET SQL_OMIT_DECLTYPE SQL_ENABLE_COLUMN_METADATA SQL_TRACE_SIZE_LIMIT SQL_OMIT_LIKE_OPTIMIZATION SQL_OMIT_OR_OPTIMIZATION SQL_OMIT_BETWEEN_OPTIMIZATION Stanislav Zudin
2019-05-29 14:01 ` [tarantool-patches] [PATCH v2 9/9] sql: cleanup code from obsolete macros Stanislav Zudin
2019-06-06 18:22 ` [tarantool-patches] Re: [PATCH v2 0/9] " n.pettik
2019-06-07 11:57   ` Stanislav Zudin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d83bb70-a1cb-061e-7d7a-1090a5cee6d2@tarantool.org \
    --to=szudin@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v2 0/9] sql: cleanup code from obsolete macros' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox