From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org, imeevma@tarantool.org
Cc: korablev@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v5 1/6] sql: remove unused macros from pragma.c and pragma.h
Date: Wed, 30 Jan 2019 16:57:03 +0300 [thread overview]
Message-ID: <0cd617a8-f3f3-7d17-4669-54ee54cc37a0@tarantool.org> (raw)
In-Reply-To: <1f667d56f6684a5cb7030097a66c4ac8b46d36cc.1548771900.git.imeevma@gmail.com>
Hi! Thanks for the patch!
On 29/01/2019 17:29, imeevma@tarantool.org wrote:
> Some macros in pragma.c and pragma.h are obsolete because the
> values they are checking are no longer used or their usage makes
> no sense. Let's remove them.
> ---
> src/box/sql/CMakeLists.txt | 2 --
> src/box/sql/parse.y | 4 ++--
> src/box/sql/pragma.c | 4 ----
> src/box/sql/pragma.h | 31 ++-----------------------------
> src/box/sql/select.c | 22 +++++++++++-----------
> src/box/sql/sqliteInt.h | 18 +-----------------
> src/box/sql/where.c | 46 ++++++++++++++++++++--------------------------
> src/box/sql/whereInt.h | 4 ++--
> 8 files changed, 38 insertions(+), 93 deletions(-)
>
> diff --git a/src/box/sql/CMakeLists.txt b/src/box/sql/CMakeLists.txt
> index 7f7b60e..68e2929 100644
> --- a/src/box/sql/CMakeLists.txt
> +++ b/src/box/sql/CMakeLists.txt
> @@ -1,7 +1,5 @@
> if(CMAKE_BUILD_TYPE STREQUAL "Debug")
> add_definitions(-DSQLITE_DEBUG=1)
> - add_definitions(-DSQLITE_ENABLE_SELECTTRACE)
Still is used in src/box/sql/printf.c.
> - add_definitions(-DSQLITE_ENABLE_WHERETRACE)
> endif()
>
next prev parent reply other threads:[~2019-01-30 13:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 14:29 [tarantool-patches] [PATCH v5 0/6] sql: set column types for EXPLAIN and PRAGMA imeevma
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 1/6] sql: remove unused macros from pragma.c and pragma.h imeevma
2019-01-30 13:57 ` Vladislav Shpilevoy [this message]
2019-01-31 14:56 ` [tarantool-patches] " Imeev Mergen
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 2/6] sql: fix "PRAGMA parser_trace" result imeevma
2019-01-30 13:57 ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-31 14:56 ` Imeev Mergen
2019-02-04 13:06 ` Vladislav Shpilevoy
2019-02-09 10:08 ` Mergen Imeev
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 3/6] sql: Show currently set sql_default_engine imeevma
2019-01-30 13:57 ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-31 14:56 ` Imeev Mergen
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 4/6] sql: fix "PRAGMA case_sensitive_like" result imeevma
2019-01-30 13:56 ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-31 14:56 ` Imeev Mergen
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 5/6] sql: get results of PRAGMA statement in YAML format imeevma
2019-01-30 13:56 ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-31 14:56 ` Imeev Mergen
2019-02-04 13:08 ` Vladislav Shpilevoy
2019-02-09 10:11 ` Mergen Imeev
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 6/6] sql: set column types for EXPLAIN and PRAGMA imeevma
2019-01-30 13:59 ` [tarantool-patches] Re: [PATCH v5 0/6] " Vladislav Shpilevoy
2019-01-31 14:56 ` Imeev Mergen
2019-02-15 20:44 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cd617a8-f3f3-7d17-4669-54ee54cc37a0@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v5 1/6] sql: remove unused macros from pragma.c and pragma.h' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox