From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org> Subject: [tarantool-patches] Re: [PATCH 6/6] sql: allow to specify UNSIGNED column type Date: Mon, 22 Jul 2019 21:17:16 +0200 [thread overview] Message-ID: <0cb431d6-e3f2-46a7-22dc-1c4971262ae5@tarantool.org> (raw) In-Reply-To: <77AF4BF0-D597-425F-A4AF-EDA7EB3901C6@tarantool.org> Hi! TLDR: LGTM. Detailed answer below. On 22/07/2019 12:20, n.pettik wrote: > > >> On 19 Jul 2019, at 00:13, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> wrote: >> >> Why are you keep trying not to fix this obvious bug? >> If that path is unreachable, then either delete it, >> or add an assertion. Or fix this place. > > Sorry, message threads now seem to be entangled a bit, > so I guess you are talking about valueFromExpr() func. > I’ve removed the single reachable to this function path, > but left function itself (valueFromExpr()) since it seem > to be quite meaningful and can be applied somewhere > later. In the next patch I’ve added assertion fault to the > place of conversion of double negative values (-(-5)): No, I was talking about mem_apply_type. With the place you are talking above I agree. Sorry, I will bring your answer from another email here: > So, you want to see smth like this: > > diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c > index 73a1f321b..835544d44 100644 > --- a/src/box/sql/vdbe.c > +++ b/src/box/sql/vdbe.c > @@ -306,8 +306,6 @@ mem_apply_type(struct Mem *record, enum field_type type) > switch (type) { > case FIELD_TYPE_INTEGER: > case FIELD_TYPE_UNSIGNED: > - if ((record->flags & MEM_Int) == MEM_Int) > - return 0; > if ((record->flags & MEM_UInt) == MEM_UInt) > return 0; > if ((record->flags & MEM_Real) == MEM_Real) { > @@ -317,7 +315,14 @@ mem_apply_type(struct Mem *record, enum field_type type) > record->u.r <= -1); > return 0; > } > - return sqlVdbeMemIntegerify(record, false); > + if (sqlVdbeMemIntegerify(record, false) != 0) > + return -1; > + if ((record->flags & MEM_Int) == MEM_Int) { > + if (type == FIELD_TYPE_UNSIGNED) > + return -1; > + return 0; > + } > + return 0; > > The difference can be seen in queries like this: > > box.execute("CREATE TABLE t1 (id UNSIGNED PRIMARY KEY);") > box.execute("INSERT INTO t1 VALUES (-3);") > --- > - error: 'Type mismatch: can not convert -3 to unsigned' > … > > Without this change we got: > 'Tuple field 1 type does not match one required by operation: expected unsigned’ > > I consider this check to be a bit inappropriate since It is redundant. > Comparison between unsigned and signed is well defined; > insertion to the unsigned field is prohibited and checked in more > low level core mechanisms. I would say I don’t mind applying this > change (and already applied to speed up review process), but on > the other side I don’t understand why do we need to add extra checks > on top (SQL) layer. I agree, all the checks should be done by box when possible. The only single problem I am talking about is not a check, but a function name mismatching what it is doing. 'mem_apply_type' does not apply unsigned type to a negative value. I just feel uncomfortable about that. The function just ignores this case. I was thinking, that perhaps some day the function mem_apply_type will evolve and consume MemCast and other functions related to type conversions, and we will forget to fix this place, and will got a bug. At this moment it is not a bug, because mem_apply_type is used only before calling comparators, which check types in box. But if someday it will be used for something else, we will forget that it ignores negative -> unsigned conversion. Anyway, never mind. The patchset LGTM.
next prev parent reply other threads:[~2019-07-22 19:15 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-07 15:37 [tarantool-patches] [PATCH 0/6] Introduce UNSIGNED type in SQL Nikita Pettik 2019-06-07 15:37 ` [tarantool-patches] [PATCH 1/6] sql: refactor sql_atoi64() Nikita Pettik 2019-06-11 21:11 ` [tarantool-patches] " Vladislav Shpilevoy 2019-07-01 14:20 ` n.pettik 2019-07-01 21:53 ` Vladislav Shpilevoy 2019-07-05 16:32 ` n.pettik 2019-06-07 15:37 ` [tarantool-patches] [PATCH 2/6] sql: separate VDBE memory holding positive and negative ints Nikita Pettik 2019-06-11 21:11 ` [tarantool-patches] " Vladislav Shpilevoy 2019-07-01 14:21 ` n.pettik 2019-07-01 21:53 ` Vladislav Shpilevoy 2019-07-05 16:33 ` n.pettik 2019-06-07 15:37 ` [tarantool-patches] [PATCH 3/6] sql: refactor arithmetic operations to support unsigned ints Nikita Pettik 2019-06-11 21:11 ` [tarantool-patches] " Vladislav Shpilevoy 2019-07-01 14:21 ` n.pettik 2019-07-01 21:53 ` Vladislav Shpilevoy 2019-07-05 16:36 ` n.pettik 2019-07-10 22:49 ` Vladislav Shpilevoy 2019-07-17 12:24 ` n.pettik 2019-06-07 15:37 ` [tarantool-patches] [PATCH 4/6] sql: make built-in functions operate on unsigned values Nikita Pettik 2019-06-11 21:11 ` [tarantool-patches] " Vladislav Shpilevoy 2019-07-01 14:21 ` n.pettik 2019-07-01 21:53 ` Vladislav Shpilevoy 2019-07-05 16:36 ` n.pettik 2019-07-10 22:49 ` Vladislav Shpilevoy 2019-07-17 0:53 ` n.pettik 2019-06-07 15:37 ` [tarantool-patches] [PATCH 5/6] sql: introduce extended range for INTEGER type Nikita Pettik 2019-06-11 21:11 ` [tarantool-patches] " Vladislav Shpilevoy 2019-07-01 14:21 ` n.pettik 2019-07-01 21:53 ` Vladislav Shpilevoy 2019-07-24 15:59 ` Konstantin Osipov 2019-07-24 16:54 ` n.pettik 2019-07-24 17:09 ` Konstantin Osipov 2019-06-07 15:37 ` [tarantool-patches] [PATCH 6/6] sql: allow to specify UNSIGNED column type Nikita Pettik 2019-07-01 21:53 ` [tarantool-patches] " Vladislav Shpilevoy 2019-07-05 16:36 ` n.pettik 2019-07-10 22:49 ` Vladislav Shpilevoy 2019-07-11 21:25 ` Vladislav Shpilevoy 2019-07-17 0:53 ` n.pettik 2019-07-18 20:18 ` Vladislav Shpilevoy 2019-07-18 20:56 ` n.pettik 2019-07-18 21:08 ` Vladislav Shpilevoy 2019-07-18 21:13 ` Vladislav Shpilevoy 2019-07-22 10:20 ` n.pettik 2019-07-22 19:17 ` Vladislav Shpilevoy [this message] 2019-07-22 10:20 ` n.pettik 2019-07-17 0:54 ` n.pettik 2019-07-18 20:18 ` Vladislav Shpilevoy 2019-08-06 19:36 ` n.pettik 2019-07-24 13:01 ` [tarantool-patches] Re: [PATCH 0/6] Introduce UNSIGNED type in SQL Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0cb431d6-e3f2-46a7-22dc-1c4971262ae5@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=korablev@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH 6/6] sql: allow to specify UNSIGNED column type' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox