From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: tarantool-patches@dev.tarantool.org, sergepetrenko@tarantool.org, gorcunov@gmail.com Subject: [Tarantool-patches] [PATCH v2 08/10] [tosquash] raft: pass source instance_id to raft_process_msg() Date: Fri, 4 Sep 2020 00:51:23 +0200 [thread overview] Message-ID: <0c95ea354508c81670fb691ab538f3f803bb8e94.1599173312.git.v.shpilevoy@tarantool.org> (raw) In-Reply-To: <cover.1599173312.git.v.shpilevoy@tarantool.org> Instance ID of the sender is needed in order to - be able to vote for him; - be able to remember its ID as leader ID, when it is a leader. --- src/box/applier.cc | 9 ++++----- src/box/raft.c | 3 ++- src/box/raft.h | 8 ++++++-- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/box/applier.cc b/src/box/applier.cc index 53db97d6d..5459a1dc1 100644 --- a/src/box/applier.cc +++ b/src/box/applier.cc @@ -898,7 +898,7 @@ err: } static int -apply_raft_row(struct xrow_header *row) +applier_handle_raft(struct applier *applier, struct xrow_header *row) { assert(iproto_type_is_raft_request(row->type)); @@ -906,9 +906,7 @@ apply_raft_row(struct xrow_header *row) struct vclock candidate_clock; if (xrow_decode_raft(row, &req, &candidate_clock) != 0) return -1; - - raft_process_msg(&req); - + raft_process_msg(&req, applier->instance_id); return 0; } @@ -1262,7 +1260,8 @@ applier_subscribe(struct applier *applier) if (first_row->lsn == 0) { if (unlikely(iproto_type_is_raft_request( first_row->type))) { - if (apply_raft_row(first_row) != 0) + if (applier_handle_raft(applier, + first_row) != 0) diag_raise(); } applier_signal_ack(applier); diff --git a/src/box/raft.c b/src/box/raft.c index 7697809ee..4d3d07c48 100644 --- a/src/box/raft.c +++ b/src/box/raft.c @@ -78,8 +78,9 @@ raft_process_recovery(const struct raft_request *req) } void -raft_process_msg(const struct raft_request *req) +raft_process_msg(const struct raft_request *req, uint32_t source) { + (void)source; if (req->term > raft.term) { // Update term. // The logic will be similar, but the code diff --git a/src/box/raft.h b/src/box/raft.h index e3261454b..db64cf933 100644 --- a/src/box/raft.h +++ b/src/box/raft.h @@ -70,9 +70,13 @@ raft_is_enabled(void) void raft_process_recovery(const struct raft_request *req); -/** Process a raft status message coming from the network. */ +/** + * Process a raft status message coming from the network. + * @param req Raft request. + * @param source Instance ID of the message sender. + */ void -raft_process_msg(const struct raft_request *req); +raft_process_msg(const struct raft_request *req, uint32_t source); /** Configure whether Raft is enabled. */ void -- 2.21.1 (Apple Git-122.3)
next prev parent reply other threads:[~2020-09-03 22:51 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-03 22:51 [Tarantool-patches] [PATCH v2 00/10] dRaft Vladislav Shpilevoy 2020-09-03 22:51 ` [Tarantool-patches] [PATCH v2 01/10] applier: store instance_id in struct applier Vladislav Shpilevoy 2020-09-04 8:13 ` Serge Petrenko 2020-09-07 22:54 ` Vladislav Shpilevoy 2020-09-03 22:51 ` [Tarantool-patches] [PATCH v2 10/10] raft: introduce box.info.raft Vladislav Shpilevoy 2020-09-04 11:38 ` Serge Petrenko 2020-09-03 22:51 ` [Tarantool-patches] [PATCH v2 02/10] box: introduce summary RO flag Vladislav Shpilevoy 2020-09-04 8:17 ` Serge Petrenko 2020-09-03 22:51 ` [Tarantool-patches] [PATCH v2 03/10] wal: don't touch box.cfg.wal_dir more than once Vladislav Shpilevoy 2020-09-04 8:20 ` Serge Petrenko 2020-09-03 22:51 ` [Tarantool-patches] [PATCH v2 04/10] replication: track registered replica count Vladislav Shpilevoy 2020-09-04 8:24 ` Serge Petrenko 2020-09-07 22:54 ` Vladislav Shpilevoy 2020-09-07 15:45 ` Sergey Ostanevich 2020-09-07 22:54 ` Vladislav Shpilevoy 2020-09-03 22:51 ` [Tarantool-patches] [PATCH v2 05/10] raft: introduce persistent raft state Vladislav Shpilevoy 2020-09-04 8:59 ` Serge Petrenko 2020-09-03 22:51 ` [Tarantool-patches] [PATCH v2 06/10] raft: introduce box.cfg.raft_* options Vladislav Shpilevoy 2020-09-04 9:07 ` Serge Petrenko 2020-09-07 22:55 ` Vladislav Shpilevoy 2020-09-03 22:51 ` [Tarantool-patches] [PATCH v2 07/10] raft: relay status updates to followers Vladislav Shpilevoy 2020-09-03 22:51 ` Vladislav Shpilevoy [this message] 2020-09-04 9:22 ` [Tarantool-patches] [PATCH v2 08/10] [tosquash] raft: pass source instance_id to raft_process_msg() Serge Petrenko 2020-09-03 22:51 ` [Tarantool-patches] [PATCH v2 09/10] raft: introduce state machine Vladislav Shpilevoy 2020-09-04 11:36 ` Serge Petrenko 2020-09-07 22:57 ` Vladislav Shpilevoy 2020-09-09 8:04 ` Serge Petrenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0c95ea354508c81670fb691ab538f3f803bb8e94.1599173312.git.v.shpilevoy@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=gorcunov@gmail.com \ --cc=sergepetrenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 08/10] [tosquash] raft: pass source instance_id to raft_process_msg()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox