From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Chris Sosnin <k.sosnin@tarantool.org>,
korablev@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] fix assertion fault in SELECT * FROM "_vfunc"
Date: Sat, 28 Mar 2020 00:37:03 +0100 [thread overview]
Message-ID: <0c7478a4-c62c-4bde-21b1-ebb6601b2def@tarantool.org> (raw)
In-Reply-To: <cover.1584608715.git.k.sosnin@tarantool.org>
Hi! Thanks for the patchset!
LGTM.
On 19/03/2020 10:14, Chris Sosnin wrote:
> First patch allows performing schema upgrades within one release.
>
> Second patch updates _vfunc format in 2.3.1.1 (the last number is not
> visible to users).
>
> branch:https://github.com/tarantool/tarantool/tree/ksosnin/gh-4666-select-from-vfunc
> issue #1:https://github.com/tarantool/tarantool/issues/4804
> issue #2:https://github.com/tarantool/tarantool/issues/4666
>
> Chris Sosnin (2):
> box: allow schema upgrades within a release
> sql: fix assertion fault in SELECT * FROM "_vfunc"
>
> src/box/bootstrap.snap | Bin 5976 -> 5970 bytes
> src/box/lua/upgrade.lua | 17 ++++++++++++++---
> test/box-py/bootstrap.result | 11 +++++++++--
> test/sql/engine.cfg | 1 +
> test/sql/gh-4666-sql-select-from-vfunc.result | 7 +++++++
> .../gh-4666-sql-select-from-vfunc.test.lua | 4 ++++
> 6 files changed, 35 insertions(+), 5 deletions(-)
> create mode 100644 test/sql/gh-4666-sql-select-from-vfunc.result
> create mode 100644 test/sql/gh-4666-sql-select-from-vfunc.test.lua
>
next prev parent reply other threads:[~2020-03-27 23:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 9:14 Chris Sosnin
2020-03-19 9:14 ` [Tarantool-patches] [PATCH 1/2] box: allow schema upgrades within a release Chris Sosnin
2020-03-22 19:43 ` Vladislav Shpilevoy
2020-03-25 19:10 ` Chris Sosnin
2020-03-19 9:14 ` [Tarantool-patches] [PATCH 2/2] sql: fix assertion fault in SELECT * FROM "_vfunc" Chris Sosnin
2020-03-22 19:42 ` Vladislav Shpilevoy
2020-03-25 19:18 ` Chris Sosnin
2020-03-27 23:37 ` Vladislav Shpilevoy [this message]
2020-04-24 10:14 [Tarantool-patches] [PATCH 0/2] " Chris Sosnin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c7478a4-c62c-4bde-21b1-ebb6601b2def@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=k.sosnin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] fix assertion fault in SELECT * FROM "_vfunc"' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox