[Tarantool-patches] [PATCH luajit v2 0/2] Checkhook CI improvements

[Tarantool-patches] [PATCH luajit v2 0/2] Checkhook CI improvements

[Sergey Kaplun via Tarantool-patches]

Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-ci-checkhook

Changes in v2:
* Separate arm64 introducing and checkhook itself in separate commits.

Sergey Kaplun (2):
  ci: add arm64 architecture to exotic testing
  ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix

 .github/workflows/exotic-builds-testing.yml | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

-- 
2.34.1

[Tarantool-patches] [PATCH luajit v2 1/2] ci: add arm64 architecture to exotic testing

[Sergey Kaplun via Tarantool-patches]

This commit adds the matrix column with CPU architecture dependency to
be used in future workflows. However, the dual-number mode is default
for arm64 in LuaJIT, so its excluded from the matrix.
---
 .github/workflows/exotic-builds-testing.yml | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
index cd0c14d7..845ae864 100644
--- a/.github/workflows/exotic-builds-testing.yml
+++ b/.github/workflows/exotic-builds-testing.yml
@@ -29,11 +29,12 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  test-x86_64-exotic:
+  test-exotic:
     strategy:
       fail-fast: false
       matrix:
         BUILDTYPE: [Debug, Release]
+        ARCH: [ARM64, x86_64]
         GC64: [ON, OFF]
         FLAVOR: [dualnum]
         include:
@@ -43,10 +44,14 @@ jobs:
             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
           - FLAVOR: dualnum
             FLAVORFLAGS: -DLUAJIT_NUMMODE=2
-    runs-on: [self-hosted, regular, Linux, x86_64]
+        exclude:
+          # DUALNUM is default for ARM64, no need for additional testing.
+          - FLAVOR: dualnum
+            ARCH: ARM64
+    runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}']
     name: >
       LuaJIT ${{ matrix.FLAVOR }}
-      (Linux/x86_64)
+      (Linux/${{ matrix.ARCH }})
       ${{ matrix.BUILDTYPE }}
       GC64:${{ matrix.GC64 }}
     steps:
-- 
2.34.1

[Tarantool-patches] [PATCH luajit v2 2/2] ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix

[Sergey Kaplun via Tarantool-patches]

This commit adds the build with the aforementioned option to test
on x86_64 and arm64 architectures to exotic build matrix.
---
 .github/workflows/exotic-builds-testing.yml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
index 845ae864..aaf4f9f6 100644
--- a/.github/workflows/exotic-builds-testing.yml
+++ b/.github/workflows/exotic-builds-testing.yml
@@ -36,7 +36,7 @@ jobs:
         BUILDTYPE: [Debug, Release]
         ARCH: [ARM64, x86_64]
         GC64: [ON, OFF]
-        FLAVOR: [dualnum]
+        FLAVOR: [dualnum, checkhook]
         include:
           - BUILDTYPE: Debug
             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
@@ -44,6 +44,8 @@ jobs:
             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
           - FLAVOR: dualnum
             FLAVORFLAGS: -DLUAJIT_NUMMODE=2
+          - FLAVOR: checkhook
+            FLAVORFLAGS: -DLUAJIT_ENABLE_CHECKHOOK=ON
         exclude:
           # DUALNUM is default for ARM64, no need for additional testing.
           - FLAVOR: dualnum
-- 
2.34.1

Re: [Tarantool-patches] [PATCH luajit v2 0/2] Checkhook CI improvements

[Igor Munkin via Tarantool-patches]

Sergey,

Thanks for the changes! LGTM now. I've checked the patch into all
long-term branches in tarantool/luajit.

On 13.02.23, Sergey Kaplun wrote:
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-ci-checkhook
> 
> Changes in v2:
> * Separate arm64 introducing and checkhook itself in separate commits.
> 
> Sergey Kaplun (2):
>   ci: add arm64 architecture to exotic testing
>   ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix
> 
>  .github/workflows/exotic-builds-testing.yml | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> -- 
> 2.34.1
> 

-- 
Best regards,
IM