From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v9 2/2] relay: provide information about downstream lag
Date: Mon, 21 Jun 2021 23:16:12 +0200 [thread overview]
Message-ID: <0b93bfab-4640-fc94-5741-375f06facce7@tarantool.org> (raw)
In-Reply-To: <YNC7kGxi4lU90p7g@grain>
Thanks for the fixes!
On 21.06.2021 18:17, Cyrill Gorcunov wrote:
> On Sun, Jun 20, 2021 at 04:37:21PM +0200, Vladislav Shpilevoy wrote:
>> Hi! Thanks for the patch!
>>
>> The test fails when I run it multiple times:
>>
>> [014] Test failed! Result content mismatch:
>> [014] --- replication/gh-5447-downstream-lag.result Sun Jun 20 16:10:26 2021
>> [014] +++ var/rejects/replication/gh-5447-downstream-lag.reject Sun Jun 20 16:33:01 2021
>> [014] @@ -37,7 +37,7 @@
>> [014] -- Upon replica startup there is no ACKs to process.
>> [014] assert(box.info.replication[replica_id].downstream.lag == 0)
>> [014] | ---
>> [014] - | - true
>> [014] + | - error: assertion failed!
>>
>> See 4 comments below.
>
> Vlad, here is an update, I force pushed it into the same branch.
> I'll fix the error injection nit. Could you please retry the
> test to run simultaneously (I did it locally with 200 tests
> but it didn't trigger anything). I rebased the series on top
> of master.
Strangely, I couldn't reproduce it again. Neither with the old
version, nor with the updated one.
The fixes look good. Please, squash, and fix the error injection
comment.
prev parent reply other threads:[~2021-06-21 21:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 15:48 [Tarantool-patches] [PATCH v9 0/2] relay: provide downstream lag information Cyrill Gorcunov via Tarantool-patches
2021-06-17 15:48 ` [Tarantool-patches] [PATCH v9 1/2] applier: send transaction's first row WAL time in the applier_writer_f Cyrill Gorcunov via Tarantool-patches
2021-06-18 9:51 ` Serge Petrenko via Tarantool-patches
2021-06-18 18:06 ` Cyrill Gorcunov via Tarantool-patches
2021-06-21 8:35 ` Serge Petrenko via Tarantool-patches
2021-06-17 15:48 ` [Tarantool-patches] [PATCH v9 2/2] relay: provide information about downstream lag Cyrill Gorcunov via Tarantool-patches
2021-06-18 9:50 ` Serge Petrenko via Tarantool-patches
2021-06-20 14:37 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 8:44 ` Cyrill Gorcunov via Tarantool-patches
2021-06-21 16:17 ` Cyrill Gorcunov via Tarantool-patches
2021-06-21 21:16 ` Vladislav Shpilevoy via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b93bfab-4640-fc94-5741-375f06facce7@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v9 2/2] relay: provide information about downstream lag' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox