From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E51466EC58; Tue, 22 Jun 2021 00:16:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E51466EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1624310176; bh=ICHNWAo1WmSy3na7hbXTduGkkluI4cCuVlkeUp6HLeA=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=VYb4q4RyB5JiGF9ggQMNyAk5zXhcLjehJY25I2bTmMw7ZDGwRDZ47eljEWJ1oKhLz Yma+h10dAlJpD6afl7vBfIlWPdJn3ZpjS72wUVDTSFE8DK3M/H+/wrJlG+ly6bXynz i831ydPLSGTvhi3Pp84a8z7NUrPoNnawzJlpxg7g= Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7A7446EC58 for ; Tue, 22 Jun 2021 00:16:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7A7446EC58 Received: by smtp3.mail.ru with esmtpa (envelope-from ) id 1lvRHC-0006UN-0e; Tue, 22 Jun 2021 00:16:14 +0300 To: Cyrill Gorcunov Cc: tml References: <20210617154835.315576-1-gorcunov@gmail.com> <20210617154835.315576-3-gorcunov@gmail.com> <909ea97e-9b56-d327-860b-65aba685fce3@tarantool.org> Message-ID: <0b93bfab-4640-fc94-5741-375f06facce7@tarantool.org> Date: Mon, 21 Jun 2021 23:16:12 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91C2C07775F13263A38E2610A94B554561BE460F683D6B25800894C459B0CD1B9E865534084D2639EC9FF7EC7F25333A5272EDE1CD7CF2EA69EED9D81CC76A58E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7548C33FFD72831AFEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063770995E888C5C26978638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D83878A5A64E27C49213D78DA4E0C5795C117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD1828451B159A507268D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4B86750DBF4DC650F2D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE37BD21ED50D08CA4D9735652A29929C6CC4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824A2A04A2ABAA09D25379311020FFC8D4AD60448F47C8B4E26F05724CAE98BB8BE3 X-C1DE0DAB: 0D63561A33F958A5E32AB8D42067AA5EC2CF384DF590634017FE19A4E2DA0137D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344A431191C56981FE7C328E564AE1144E607F77F946C1621AA378C324954FC5EFC3728C20398800FC1D7E09C32AA3244C7897FFEF972F589EE16F52CE64873019A995755A1445935E729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrAWM8Mt/TODXGf0ya70cHQ== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA3110CE610304AC19143C1974122C23D1DB21976AF1CB91E68C8107784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v9 2/2] relay: provide information about downstream lag X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the fixes! On 21.06.2021 18:17, Cyrill Gorcunov wrote: > On Sun, Jun 20, 2021 at 04:37:21PM +0200, Vladislav Shpilevoy wrote: >> Hi! Thanks for the patch! >> >> The test fails when I run it multiple times: >> >> [014] Test failed! Result content mismatch: >> [014] --- replication/gh-5447-downstream-lag.result Sun Jun 20 16:10:26 2021 >> [014] +++ var/rejects/replication/gh-5447-downstream-lag.reject Sun Jun 20 16:33:01 2021 >> [014] @@ -37,7 +37,7 @@ >> [014] -- Upon replica startup there is no ACKs to process. >> [014] assert(box.info.replication[replica_id].downstream.lag == 0) >> [014] | --- >> [014] - | - true >> [014] + | - error: assertion failed! >> >> See 4 comments below. > > Vlad, here is an update, I force pushed it into the same branch. > I'll fix the error injection nit. Could you please retry the > test to run simultaneously (I did it locally with 200 tests > but it didn't trigger anything). I rebased the series on top > of master. Strangely, I couldn't reproduce it again. Neither with the old version, nor with the updated one. The fixes look good. Please, squash, and fix the error injection comment.