Re: [Tarantool-patches] [PATCH luajit 3/3] macOS: Remove obsolete -single_module flag.

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 2445 bytes --]

Hi, Sergey,

thanks for the patch! LGTM with two minor comments.

Sergey

On 11/24/25 23:26, Sergey Kaplun wrote:
> From: Mike Pall <mike>
>
> Thanks to dundargoc.
>
> (cherry picked from commit 97813fb924edf822455f91a5fbbdfdb349e5984f)
>
> The aforementioned flag is the default since Xcode 2.2 [1].

You refer to the description in the previous commit, right?

I would name a flag here instead

> This patch removes this flag to avoid warnings for modern Xcode
> versions at the linking stage.
it is worth to mention our own modifications for CMake build system
>
> [1]:https://bugzilla.mozilla.org/show_bug.cgi?id=1743539#c1
>
> Sergey Kaplun:
> * added the description for the problem
>
> Part of tarantool/tarantool#11691
> ---
>   cmake/SetTargetFlags.cmake | 2 +-
>   src/Makefile.original      | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake
> index d6ee1693..a0f9d45a 100644
> --- a/cmake/SetTargetFlags.cmake
> +++ b/cmake/SetTargetFlags.cmake
> @@ -47,7 +47,7 @@ if(LUAJIT_ARCH STREQUAL "x86")
>   endif()
>   
>   if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
> -  AppendFlags(TARGET_SHARED_FLAGS -single_module -undefined dynamic_lookup)
> +  AppendFlags(TARGET_SHARED_FLAGS -undefined dynamic_lookup)
>   else() # Linux and FreeBSD.
>     AppendFlags(TARGET_BIN_FLAGS -Wl,-E)
>     list(APPEND TARGET_LIBS dl)
> diff --git a/src/Makefile.original b/src/Makefile.original
> index 8d925e3a..471d692c 100644
> --- a/src/Makefile.original
> +++ b/src/Makefile.original
> @@ -329,13 +329,13 @@ ifeq (Darwin,$(TARGET_SYS))
>     endif
>     TARGET_STRIP+= -x
>     TARGET_XCFLAGS+= -DLUAJIT_UNWIND_EXTERNAL
> -  TARGET_XSHLDFLAGS= -dynamiclib -single_module -undefined dynamic_lookup -fPIC
> +  TARGET_XSHLDFLAGS= -dynamiclib -undefined dynamic_lookup -fPIC
>     TARGET_DYNXLDOPTS=
>     TARGET_XSHLDFLAGS+= -install_name $(TARGET_DYLIBPATH) -compatibility_version $(MAJVER).$(MINVER) -current_version $(MAJVER).$(MINVER).$(RELVER)
>   else
>   ifeq (iOS,$(TARGET_SYS))
>     TARGET_STRIP+= -x
> -  TARGET_XSHLDFLAGS= -dynamiclib -single_module -undefined dynamic_lookup -fPIC
> +  TARGET_XSHLDFLAGS= -dynamiclib -undefined dynamic_lookup -fPIC
>     TARGET_DYNXLDOPTS=
>     TARGET_XSHLDFLAGS+= -install_name $(TARGET_DYLIBPATH) -compatibility_version $(MAJVER).$(MINVER) -current_version $(MAJVER).$(MINVER).$(RELVER)
>     ifeq (arm64,$(TARGET_LJARCH))

[-- Attachment #2: Type: text/html, Size: 3312 bytes --]