From: "Timur Safin" <tsafin@tarantool.org>
To: 'Igor Munkin' <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org,
alexander.turenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2.X 3/7] module api: luaT_newthread
Date: Fri, 2 Oct 2020 19:12:25 +0300 [thread overview]
Message-ID: <0acd01d698d6$d1a23460$74e69d20$@tarantool.org> (raw)
In-Reply-To: <20200929151946.GZ18920@tarantool.org>
: From: Igor Munkin <imun@tarantool.org>
: Subject: Re: [Tarantool-patches] [PATCH 2.X 3/7] module api:
: luaT_newthread
:
: Timur,
:
: Thanks for the patch, but I guess this one can be implemented using the
: existing public interfaces (i.e. Lua C standart API + already exported
: <luaT_call>). It was done to resolve the issue with Tarantool internal
: crash[1] and I believe if user need to handle OOM error it can do it by
: himself.
:
: [1]: https://github.com/tarantool/tarantool/issues/4556
:
: --
: Best regards,
: IM
I do not quite get your point here - here we do want to use that newly
introduced wrapper luaT_newthread in the external module. Do you suggest
we reimplement it similarly in the external module? We tried and incr_top()
was the problematic if we live outside of Tarantool core.
Or do you mean that we do not want to deal with incr_top(L) from outside?
Timur
next prev parent reply other threads:[~2020-10-02 16:12 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 17:00 [Tarantool-patches] [PATCH 2.X 0/7] RFC: module api: extend for external merger Lua module Timur Safin
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 1/7] module api: export box_tuple_validate Timur Safin
2020-09-28 22:20 ` Vladislav Shpilevoy
2020-10-02 12:24 ` Timur Safin
2020-10-09 1:11 ` Alexander Turenko
2020-10-09 20:11 ` Vladislav Shpilevoy
2020-10-10 1:19 ` Alexander Turenko
2020-09-29 5:25 ` Alexander Turenko
2020-10-05 7:35 ` Alexander Turenko
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 2/7] module api: export box_key_def_dup Timur Safin
2020-09-28 22:21 ` Vladislav Shpilevoy
2020-09-29 5:03 ` Alexander Turenko
2020-09-29 23:19 ` Vladislav Shpilevoy
2020-10-01 3:05 ` Alexander Turenko
2020-10-02 12:25 ` Timur Safin
2020-10-02 12:26 ` Timur Safin
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 3/7] module api: luaT_newthread Timur Safin
2020-09-28 22:21 ` Vladislav Shpilevoy
2020-10-02 12:27 ` Timur Safin
2020-10-02 21:48 ` Vladislav Shpilevoy
2020-09-29 6:25 ` Alexander Turenko
2020-10-02 12:26 ` Timur Safin
2020-10-02 12:53 ` Alexander Turenko
2020-09-29 15:19 ` Igor Munkin
2020-10-02 16:12 ` Timur Safin [this message]
2020-10-03 16:57 ` Igor Munkin
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 4/7] module api: luaL_register_module & luaL_register_type Timur Safin
2020-09-28 22:21 ` Vladislav Shpilevoy
2020-09-29 5:09 ` Alexander Turenko
2020-09-29 23:20 ` Vladislav Shpilevoy
2020-09-30 6:31 ` Alexander Turenko
2020-09-30 6:33 ` Alexander Turenko
2020-10-02 16:14 ` Timur Safin
2020-09-29 8:03 ` Igor Munkin
2020-09-29 23:21 ` Vladislav Shpilevoy
2020-10-02 16:14 ` Timur Safin
2020-10-03 3:24 ` Alexander Turenko
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 5/7] module api: luaT_temp_luastate & luaT_release_temp_luastate Timur Safin
2020-09-28 22:21 ` Vladislav Shpilevoy
2020-09-29 5:17 ` Alexander Turenko
2020-09-29 23:21 ` Vladislav Shpilevoy
2020-10-01 3:35 ` Alexander Turenko
2020-09-29 15:10 ` Igor Munkin
2020-09-29 21:03 ` Alexander Turenko
2020-09-29 23:23 ` Vladislav Shpilevoy
2020-09-30 10:09 ` Alexander Turenko
2020-10-01 15:06 ` Igor Munkin
2020-10-03 2:16 ` Alexander Turenko
2020-10-02 12:24 ` Timur Safin
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 6/7] module api: luaL_checkibuf & luaL_checkconstchar Timur Safin
2020-09-28 22:21 ` Vladislav Shpilevoy
2020-09-29 5:53 ` Alexander Turenko
2020-09-29 23:25 ` Vladislav Shpilevoy
2020-10-01 3:00 ` Alexander Turenko
2020-10-02 16:14 ` Timur Safin
2020-10-02 21:48 ` Vladislav Shpilevoy
2020-10-08 13:50 ` Timur Safin
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 7/7] module api: luaL_cdata_iscallable Timur Safin
2020-09-28 22:21 ` Vladislav Shpilevoy
2020-09-29 5:19 ` Alexander Turenko
2020-10-02 16:14 ` Timur Safin
2020-10-02 12:23 ` [Tarantool-patches] [PATCH 2.X 0/7] RFC: module api: extend for external merger Lua module Timur Safin
2020-10-02 21:49 ` Vladislav Shpilevoy
2020-10-03 2:54 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0acd01d698d6$d1a23460$74e69d20$@tarantool.org' \
--to=tsafin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2.X 3/7] module api: luaT_newthread' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox