From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/2] Simplify alter.cc
Date: Wed, 8 Jul 2020 12:13:05 +0300 [thread overview]
Message-ID: <0a5f2a55-7233-c34d-74ed-6d601138f945@tarantool.org> (raw)
In-Reply-To: <1594199230-26036-1-git-send-email-alyapunov@tarantool.org>
+Ilya Kosarev
and forgot again:
GH issue: https://github.com/tarantool/tarantool/issues/5153
GH branch:
https://github.com/tarantool/tarantool/tree/alyapunov/gh-5153-simplify-alter-cc
On 08.07.2020 12:07, Aleksandr Lyapunov wrote:
> Since we use C++ we need to use in a way that benefits its advantages.
> As I see, there are tons of try-catch blocks in alter.cc. We should use more modern techniques and approaches.
>
> Aleksandr Lyapunov (2):
> alter: use good c++ style
> alter: use proper way to marry C and C++
>
> src/box/alter.cc | 418 +++++++++++++++++++++++--------------------------------
> 1 file changed, 177 insertions(+), 241 deletions(-)
>
next prev parent reply other threads:[~2020-07-08 9:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 9:07 Aleksandr Lyapunov
2020-07-08 9:07 ` [Tarantool-patches] [PATCH 1/2] alter: use good c++ style Aleksandr Lyapunov
2020-07-11 19:53 ` Vladislav Shpilevoy
2020-07-13 13:36 ` Aleksandr Lyapunov
2020-07-13 18:33 ` Vladislav Shpilevoy
2020-07-13 21:51 ` Timur Safin
2020-07-13 22:17 ` Vladislav Shpilevoy
2020-07-08 9:07 ` [Tarantool-patches] [PATCH 2/2] alter: use proper way to marry C and C++ Aleksandr Lyapunov
2020-07-08 10:41 ` Timur Safin
2020-07-11 19:53 ` Vladislav Shpilevoy
2020-07-08 9:13 ` Aleksandr Lyapunov [this message]
2020-07-08 10:35 ` [Tarantool-patches] [PATCH 0/2] Simplify alter.cc Timur Safin
-- strict thread matches above, loose matches on Subject: below --
2020-07-08 8:43 Aleksandr Lyapunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a5f2a55-7233-c34d-74ed-6d601138f945@tarantool.org \
--to=alyapunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] Simplify alter.cc' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox