From: "Timur Safin" <tsafin@tarantool.org> To: 'Vladislav Shpilevoy' <v.shpilevoy@tarantool.org>, 'HustonMmmavr' <huston.mavr@gmail.com>, tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@gmail.com, alexander.turenko@tarantool.org Subject: Re: [Tarantool-patches] [PATCH] Add missed icu symbols Date: Tue, 22 Sep 2020 00:05:25 +0300 [thread overview] Message-ID: <0a4d01d6905a$ed4c1110$c7e43330$@tarantool.org> (raw) In-Reply-To: <a7a60fd5-cf23-07d7-3f0a-9b7186668161@tarantool.org> : From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> : Subject: Re: [PATCH] Add missed icu symbols : ... : > +EXPORT(u_strlen) : > +EXPORT(u_uastrcpy) : > +EXPORT(u_austrcpy) : > +EXPORT(u_errorName) : > +EXPORT(u_getVersion) : > +EXPORT(udat_open) : > +EXPORT(udat_setLenient) : > +EXPORT(udat_close) : > +EXPORT(udat_parseCalendar) : > +#if U_ICU_VERSION_MAJOR_NUM >= 55 : > + EXPORT(udat_formatCalendar) : > +#endif : > +EXPORT(ucal_open) : > +EXPORT(ucal_close) : > +EXPORT(ucal_get) : > +EXPORT(ucal_set) : > +EXPORT(ucal_add) : > +EXPORT(ucal_clear) : > +EXPORT(ucal_clearField) : > +EXPORT(ucal_getMillis) : > +EXPORT(ucal_setMillis) : > +EXPORT(ucal_getAttribute) : > +EXPORT(ucal_setAttribute) : > +#if U_ICU_VERSION_MAJOR_NUM >= 51 : > + EXPORT(ucal_getTimeZoneID) : > +#endif : > +EXPORT(ucal_setTimeZone) : > +EXPORT(ucal_getNow) : : 3. Lets better store everything in exports.h. You can add a new : section in this file separated by a comment, that these symbols are : from ICU, to not scatter them among other exports. Also please sort : the exports in the alphabetical order, as it is asked in exports.h : comment. Agreed with Vlad here - keeping all inside of single exports.h would make this code much, much easier to maintain. I'd recommend you to return back to the original idea with using special EXPORT_ICU(name) macros which would expand to EXPORT(U_ICU_ENTRY_POINT_RENAME(name)) _iff_ not U_DISABLE_RENAMING and to EXPORT(name) otherwise. And for +#if U_ICU_VERSION_MAJOR_NUM >= 51 I'd suggest (but not insist) to create yet another wrapper EXPORT_ICU_51UP(name). This would make it looks very consistent with others. Though with 1 usage case it might be overkill. Regards, Timur
next prev parent reply other threads:[~2020-09-21 21:05 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-21 19:51 HustonMmmavr 2020-09-21 20:29 ` Vladislav Shpilevoy 2020-09-21 21:05 ` Timur Safin [this message] 2020-09-22 22:20 ` Alexandr Barulev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='0a4d01d6905a$ed4c1110$c7e43330$@tarantool.org' \ --to=tsafin@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=huston.mavr@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --cc=yaroslav.dynnikov@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH] Add missed icu symbols' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox