From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: raise error for DELETE FROM nonexistent table
Date: Mon, 16 Jul 2018 18:13:45 +0300 [thread overview]
Message-ID: <0D0A4FC9-E74F-4C63-A87B-950215B1F517@tarantool.org> (raw)
In-Reply-To: <8ea2b4731ccf9d79140d17f87a6a1ed05f9948d8.1531753721.git.kshcherbatov@tarantool.org>
> On 16 Jul 2018, at 18:09, Kirill Shcherbatov <kshcherbatov@tarantool.org> wrote:
>
> Parser didn't raise error when DELETE FROM can't find
> a table specified on statement.
> As no error was raised, partially-prepared VDBE code
> seemed to be generated fine, that was not true.
>
> Closes #3535.
> —
LGTM. It seems that your patch also closes #3511 issue.
If so, add also test for that case and ticket number to commit message
(to close it automatically).
next prev parent reply other threads:[~2018-07-16 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 15:09 [tarantool-patches] " Kirill Shcherbatov
2018-07-16 15:13 ` n.pettik [this message]
2018-07-19 10:48 ` [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0D0A4FC9-E74F-4C63-A87B-950215B1F517@tarantool.org \
--to=korablev@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: raise error for DELETE FROM nonexistent table' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox