From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v8 2/3] sql: return all generated ids via IPROTO
Date: Fri, 9 Nov 2018 10:51:52 +0300 [thread overview]
Message-ID: <0A5351C3-C53C-463E-A48F-9B653E464566@tarantool.org> (raw)
In-Reply-To: <81dc397f-aa49-15b2-5416-1f11931a11e5@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
> Hi! Thank you for review! My answer, diff between patches and new
> patch below. Changes were made only in commit named by "sql:
> return all generated ids via IPROTO". After changes were made and
> diff saved I rebased this branch to current 2.1. After this new
> patch description were formed, so it is a bit different from
> old patch with applied diff.
Now LGTM (as well as whole patch-set).
[-- Attachment #2: Type: text/html, Size: 5484 bytes --]
next prev parent reply other threads:[~2018-11-09 7:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 17:33 [tarantool-patches] [PATCH v8 0/3] " imeevma
2018-10-29 17:33 ` [tarantool-patches] [PATCH v8 1/3] box: factor fiber_gc out of txn_commit imeevma
2018-10-30 14:30 ` [tarantool-patches] " n.pettik
2018-10-30 19:15 ` Vladislav Shpilevoy
2018-10-30 20:03 ` Vladislav Shpilevoy
2018-10-30 20:06 ` Vladislav Shpilevoy
2018-10-30 21:32 ` Vladislav Shpilevoy
2018-10-30 23:08 ` n.pettik
2018-10-31 9:18 ` Vladislav Shpilevoy
2018-10-31 9:30 ` n.pettik
2018-10-29 17:33 ` [tarantool-patches] [PATCH v8 2/3] sql: return all generated ids via IPROTO imeevma
2018-10-30 14:30 ` [tarantool-patches] " n.pettik
2018-11-02 18:52 ` Imeev Mergen
2018-11-09 7:51 ` n.pettik [this message]
2018-10-29 17:33 ` [tarantool-patches] [PATCH v8 3/3] sql: remove psql_txn from Vdbe imeevma
2018-10-30 14:30 ` [tarantool-patches] " n.pettik
2018-10-30 19:41 ` Vladislav Shpilevoy
2018-11-09 8:02 ` [tarantool-patches] Re: [PATCH v8 0/3] sql: return all generated ids via IPROTO Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0A5351C3-C53C-463E-A48F-9B653E464566@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v8 2/3] sql: return all generated ids via IPROTO' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox