From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: Kirill Shcherbatov <kshcherbatov@tarantool.org>, Tarantool MailList <tarantool-patches@freelists.org> Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: improve vdbe_field_ref fetcher Date: Thu, 15 Aug 2019 23:16:49 +0200 [thread overview] Message-ID: <09af6c7e-1a6f-4736-5f34-3f65b2266d45@tarantool.org> (raw) In-Reply-To: <2683f8ca-9fe0-a0e6-7433-9bfa4745f4f4@tarantool.org> Hi! Thanks for the fixes. See 2 comments below. > diff --git a/test/sql/misc.test.lua b/test/sql/misc.test.lua > index fdc19f3ac..afbb2d7f8 100644 > --- a/test/sql/misc.test.lua > +++ b/test/sql/misc.test.lua > @@ -35,3 +35,25 @@ s = box.schema.space.create('s',{format=format, temporary=true}) > i = s:create_index('i') > box.execute('select * from "s"') > s:drop() > + > +-- > +-- gh-4267: Full power of vdbe_field_ref > +-- The test consists of sequential reads of multiple fields: > +-- the first is indexed while the other are not indexed. > +-- In skope of this issue an optimization that makes second and 1. 'scope'. > +-- third lookups faster were introduced. Test that they works > +-- correctly. 2. This is not an explanation, but rather a bit of water. With the same explanation you could test fields 1 and 2. Please, explain why exactly these numbers. Also you somewhy dropped the previous test on the border case about a field < 64 and >= 64 in one request. Why? The test below does not cover it. > +-- > +format = {} > +t = {} > +test_run:cmd("setopt delimiter ';'") > +for i = 1, 70 do > + format[i] = {name = 'FIELD'..i, type = 'unsigned'} > + t[i] = i > +end > +test_run:cmd("setopt delimiter ''"); For such a small piece of code you could use '\' instead of setopt delimiter. IMO \ looks much better. Up to you. > +s = box.schema.create_space('TEST', {format = format}) > +pk = s:create_index('pk', {parts = {66}}) > +s:insert(t) > +box.execute('SELECT field66, field68, field70 FROM test') > +box.space.TEST:drop() >
next prev parent reply other threads:[~2019-08-15 21:14 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-22 7:43 [tarantool-patches] " Kirill Shcherbatov 2019-07-22 8:45 ` [tarantool-patches] " Kirill Shcherbatov 2019-08-08 21:13 ` Vladislav Shpilevoy 2019-08-12 15:14 ` Kirill Shcherbatov 2019-08-13 21:23 ` Vladislav Shpilevoy 2019-08-14 10:24 ` Kirill Shcherbatov 2019-08-14 20:18 ` Vladislav Shpilevoy 2019-08-15 8:39 ` Kirill Shcherbatov 2019-08-15 21:16 ` Vladislav Shpilevoy [this message] 2019-08-16 7:49 ` Kirill Shcherbatov 2019-08-19 20:00 ` Vladislav Shpilevoy 2019-08-19 20:27 ` Kirill Shcherbatov 2019-08-19 20:50 ` Vladislav Shpilevoy 2019-08-20 9:07 ` n.pettik 2019-08-20 18:46 ` Vladislav Shpilevoy 2019-08-22 12:08 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=09af6c7e-1a6f-4736-5f34-3f65b2266d45@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=kshcherbatov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: improve vdbe_field_ref fetcher' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox