From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] memtx: fix tuples references on concurrent replaces
Date: Thu, 11 Jun 2020 16:44:50 +0300 [thread overview]
Message-ID: <093060f4-abc7-ab3a-dbe3-421e0a7356dd@tarantool.org> (raw)
In-Reply-To: <20200607140859.5583-1-i.kosarev@tarantool.org>
Thanks for the patch! See my comment below.
On 6/7/20 5:08 PM, Ilya Kosarev wrote:
> + /*
> + * All tuples stored in a memtx space must be
> + * referenced by the primary index.
> + */
> + if (state->index->def->iid == 0)
> + tuple_ref(stmt->new_tuple);
I'm afraid that stmt->new_tuple can be NULL here.
Could you please create another test for this issue when some tuples are
deleted during snapshot. I bet it will crash.
next prev parent reply other threads:[~2020-06-11 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 14:08 Ilya Kosarev
2020-06-11 13:44 ` Aleksandr Lyapunov [this message]
2020-06-11 22:15 Ilya Kosarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=093060f4-abc7-ab3a-dbe3-421e0a7356dd@tarantool.org \
--to=alyapunov@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] memtx: fix tuples references on concurrent replaces' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox