Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org, sergepetrenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] applier: send heartbeat not only on commit, but on any write
Date: Tue, 30 Jun 2020 01:18:21 +0200	[thread overview]
Message-ID: <09061add-8ae0-58d7-9d9c-edad718a1b74@tarantool.org> (raw)
In-Reply-To: <96da517b-547f-d5f1-823c-f38141a04670@tarantool.org>

Appeared the transactions leak afterwards anyway.

The problem was that txn->fiber was not set to NULL for
regular async transactions anywhere in applier. So they all
leaked.

I made applier on_commit/on_rollback triggers nullify txn->fiber
so it could be freed when commit/rollback are done.

      reply	other threads:[~2020-06-29 23:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22 22:56 Vladislav Shpilevoy
2020-06-23  8:45 ` Serge Petrenko
2020-06-23 21:26   ` Vladislav Shpilevoy
2020-06-23 22:09 ` Vladislav Shpilevoy
2020-06-23 22:20   ` Vladislav Shpilevoy
2020-06-29 23:18     ` Vladislav Shpilevoy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09061add-8ae0-58d7-9d9c-edad718a1b74@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 1/1] applier: send heartbeat not only on commit, but on any write' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox