Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 3/3] macOS: Remove obsolete -single_module flag.
Date: Mon, 24 Nov 2025 23:26:38 +0300	[thread overview]
Message-ID: <08ffbaee95a92ee9c166fa70b78e2d98c06928a2.1763991490.git.skaplun@tarantool.org> (raw)
In-Reply-To: <cover.1763991490.git.skaplun@tarantool.org>

From: Mike Pall <mike>

Thanks to dundargoc.

(cherry picked from commit 97813fb924edf822455f91a5fbbdfdb349e5984f)

The aforementioned flag is the default since Xcode 2.2 [1].
This patch removes this flag to avoid warnings for modern Xcode
versions at the linking stage.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1743539#c1

Sergey Kaplun:
* added the description for the problem

Part of tarantool/tarantool#11691
---
 cmake/SetTargetFlags.cmake | 2 +-
 src/Makefile.original      | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake
index d6ee1693..a0f9d45a 100644
--- a/cmake/SetTargetFlags.cmake
+++ b/cmake/SetTargetFlags.cmake
@@ -47,7 +47,7 @@ if(LUAJIT_ARCH STREQUAL "x86")
 endif()
 
 if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
-  AppendFlags(TARGET_SHARED_FLAGS -single_module -undefined dynamic_lookup)
+  AppendFlags(TARGET_SHARED_FLAGS -undefined dynamic_lookup)
 else() # Linux and FreeBSD.
   AppendFlags(TARGET_BIN_FLAGS -Wl,-E)
   list(APPEND TARGET_LIBS dl)
diff --git a/src/Makefile.original b/src/Makefile.original
index 8d925e3a..471d692c 100644
--- a/src/Makefile.original
+++ b/src/Makefile.original
@@ -329,13 +329,13 @@ ifeq (Darwin,$(TARGET_SYS))
   endif
   TARGET_STRIP+= -x
   TARGET_XCFLAGS+= -DLUAJIT_UNWIND_EXTERNAL
-  TARGET_XSHLDFLAGS= -dynamiclib -single_module -undefined dynamic_lookup -fPIC
+  TARGET_XSHLDFLAGS= -dynamiclib -undefined dynamic_lookup -fPIC
   TARGET_DYNXLDOPTS=
   TARGET_XSHLDFLAGS+= -install_name $(TARGET_DYLIBPATH) -compatibility_version $(MAJVER).$(MINVER) -current_version $(MAJVER).$(MINVER).$(RELVER)
 else
 ifeq (iOS,$(TARGET_SYS))
   TARGET_STRIP+= -x
-  TARGET_XSHLDFLAGS= -dynamiclib -single_module -undefined dynamic_lookup -fPIC
+  TARGET_XSHLDFLAGS= -dynamiclib -undefined dynamic_lookup -fPIC
   TARGET_DYNXLDOPTS=
   TARGET_XSHLDFLAGS+= -install_name $(TARGET_DYLIBPATH) -compatibility_version $(MAJVER).$(MINVER) -current_version $(MAJVER).$(MINVER).$(RELVER)
   ifeq (arm64,$(TARGET_LJARCH))
-- 
2.51.2


  parent reply	other threads:[~2025-11-24 20:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24 20:26 [Tarantool-patches] [PATCH luajit 0/3] Various fixes for macOS Sergey Kaplun via Tarantool-patches
2025-11-24 20:26 ` [Tarantool-patches] [PATCH luajit 1/3] macOS: Fix macOS 15 / Clang 16 build Sergey Kaplun via Tarantool-patches
2025-11-25 13:56   ` Sergey Bronnikov via Tarantool-patches
2025-11-24 20:26 ` [Tarantool-patches] [PATCH luajit 2/3] macOS: Workaround for buggy XCode 15.0 - 15.2 linker Sergey Kaplun via Tarantool-patches
2025-11-26 12:09   ` Sergey Bronnikov via Tarantool-patches
2025-11-24 20:26 ` Sergey Kaplun via Tarantool-patches [this message]
2025-11-26 11:58   ` [Tarantool-patches] [PATCH luajit 3/3] macOS: Remove obsolete -single_module flag Sergey Bronnikov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08ffbaee95a92ee9c166fa70b78e2d98c06928a2.1763991490.git.skaplun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 3/3] macOS: Remove obsolete -single_module flag.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox