Re: [Tarantool-patches] [PATCH v2] recovery: make it yield when positioning in a WAL

[Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

13.05.2021 14:21, Vladislav Shpilevoy пишет:
> Hi! Good job on the fixes!
>
>> diff --git a/src/box/relay.cc b/src/box/relay.cc
>> index 81ac35bf2..efc201e80 100644
>> --- a/src/box/relay.cc
>> +++ b/src/box/relay.cc
>> @@ -262,8 +262,9 @@ relay_new(struct replica *replica)
>>
>>   /** A callback recovery calls every now and then to unblock the event loop. */
>>   static void
>> -relay_yield(void)
>> +relay_yield(struct xstream *stream)
>>   {
>> +    (void) stream;
> For unary operators we omit whitespace after them.
>
> After you fix this - LGTM!

Thanks! Fixed.

diff --git a/src/box/relay.cc b/src/box/relay.cc
index efc201e80..f721c3346 100644
--- a/src/box/relay.cc
+++ b/src/box/relay.cc
@@ -264,7 +264,7 @@ relay_new(struct replica *replica)
  static void
  relay_yield(struct xstream *stream)
  {
-       (void) stream;
+       (void)stream;
         fiber_sleep(0);
  }


-- 
Serge Petrenko