From: "Timur Safin" <tsafin@tarantool.org>
To: 'Igor Munkin' <imun@tarantool.org>,
"'Alexander V. Tikhonov'" <avtikhon@tarantool.org>,
'Alexander Turenko' <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] Remove hardcoded paths to LuaJIT tests
Date: Fri, 16 Oct 2020 15:33:17 +0300 [thread overview]
Message-ID: <086701d6a3b8$86522a50$92f67ef0$@tarantool.org> (raw)
In-Reply-To: <cover.1602846789.git.imun@tarantool.org>
I could not resist and not highlight the fact that your patch "is not
working" the same way as mine :)
https://gitlab.com/tarantool/tarantool/-/pipelines/203157106
(Or putting it the other way around - mine was working also. Being less
intrusive as patch only for single repository, not 2)
LGTM, in any case, if you prefer 2 repo patch.
P.S.
I do not know whether it means anything, but apparently Debian-based
Distros are green now, and RPM-based and others are red. Could it be
there anything special which is Debian-specific?
: -----Original Message-----
: From: Igor Munkin <imun@tarantool.org>
: Sent: Friday, October 16, 2020 3:12 PM
: To: Alexander V. Tikhonov <avtikhon@tarantool.org>; Timur Safin
: <tsafin@tarantool.org>; Alexander Turenko
: <alexander.turenko@tarantool.org>
: Cc: Igor Munkin <imun@tarantool.org>; tarantool-patches@dev.tarantool.org
: Subject: [PATCH] Remove hardcoded paths to LuaJIT tests
:
: As a result of the review[1] for Timur patch, I've finally got the idea
: how to reduce the struggling Kirill faces every time there is a new test
: created within LuaJIT third party repo. The series contains of two
: patches in both repos:
: * the root CMakeLists.txt for test directory is introduced to LuaJIT
: repo in scope of the first patch
: * the paths in test/CMakeLists.txt are accordingly adjusted
:
: Issue: https://github.com/tarantool/tarantool/issues/5425
: LuaJIT repo branches:
: * https://github.com/tarantool/luajit/tree/imun/gh-5425-luajit-tests-cmake
: * https://github.com/tarantool/luajit/tree/imun/gh-5425-luajit-tests-
: cmake-2.5
: Tarantool repo branch (need to be cherry-picked to all stable branches):
: * https://github.com/tarantool/tarantool/tree/imun/gh-5425-luajit-tests-
: cmake
:
: CI is not green, but I've done my best. I see neither build fails nor
: failures related to the luajit-tap tests here:
: * https://gitlab.com/tarantool/tarantool/-/pipelines/203537445
:
: [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-
: October/020266.html
:
: --
: 2.25.0
next prev parent reply other threads:[~2020-10-16 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 12:11 Igor Munkin
2020-10-16 12:11 ` [Tarantool-patches] [PATCH luajit] test: introduce the root CMakeLists.txt Igor Munkin
2020-10-16 12:12 ` [Tarantool-patches] [PATCH] test: adjust the path to LuaJIT test directory Igor Munkin
2020-10-16 12:33 ` Timur Safin [this message]
2020-10-16 12:47 ` [Tarantool-patches] [PATCH] Remove hardcoded paths to LuaJIT tests Igor Munkin
2020-10-16 12:59 ` Alexander V. Tikhonov
2020-10-16 12:54 ` Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='086701d6a3b8$86522a50$92f67ef0$@tarantool.org' \
--to=tsafin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] Remove hardcoded paths to LuaJIT tests' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox