From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/3] sql: clean-up vdbe_emit_constraint_checks
Date: Tue, 25 Dec 2018 19:26:19 +0200 [thread overview]
Message-ID: <083A3DBF-8AF5-45BA-AC5E-E11D5A610533@tarantool.org> (raw)
In-Reply-To: <ec9419a6c0f69d93eb0f6d71445b040f0b814bde.1545233551.git.kshcherbatov@tarantool.org>
> On 19 Dec 2018, at 17:37, Kirill Shcherbatov <kshcherbatov@tarantool.org> wrote:
>
> Removed vdbe code generation making type checks from
> vdbe_emit_constraint_checks as it is useless since strict types
> have been introduced.
>
> Needed for #3850
It doesn’t seem to be needed for #3850.
Otherwise explain why it is required for #3850.
Patch is OK.
next prev parent reply other threads:[~2018-12-25 17:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 15:37 [tarantool-patches] [PATCH v1 0/3] sql: do not use OP_Delete+OP_Insert for UPDATES Kirill Shcherbatov
2018-12-19 15:37 ` [tarantool-patches] [PATCH v1 1/3] sql: clean-up vdbe_emit_constraint_checks Kirill Shcherbatov
2018-12-25 17:26 ` n.pettik [this message]
2018-12-19 15:37 ` [tarantool-patches] [PATCH v1 2/3] sql: fix sql_vdbe_mem_alloc_region result memory Kirill Shcherbatov
2018-12-25 17:26 ` [tarantool-patches] " n.pettik
2018-12-19 15:37 ` [tarantool-patches] [PATCH v1 3/3] sql: do not use OP_Delete+OP_Insert for UPDATES Kirill Shcherbatov
2018-12-25 17:26 ` [tarantool-patches] " n.pettik
2018-12-26 8:35 ` Kirill Shcherbatov
2018-12-28 14:17 ` n.pettik
2018-12-20 20:41 ` [tarantool-patches] Re: [PATCH v1 0/3] " Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=083A3DBF-8AF5-45BA-AC5E-E11D5A610533@tarantool.org \
--to=korablev@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/3] sql: clean-up vdbe_emit_constraint_checks' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox