Re: [Tarantool-patches] [PATCH vshard 01/11] error: introduce vshard.error.timeout()

[Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi! Thanks for the review!

On 24.02.2021 11:27, Oleg Babin wrote:
> Hi! Thanks for your patch.
> 
> Personally, I vote for dropping 1.9 support (it's already broken - #256).

It kind of works. Just with some spam in the logs. But yeah, I would like
to finally drop it. I talked to Mons and he approved this:
https://github.com/tarantool/vshard/issues/267

> But if you want to eliminate "long and ugly" ways you could do something like:
> 
> 
> ```
> 
> local make_timeout
> if box.error.new ~= nil then
>     make_timeout = function() return box.error.new(box.error.TIMEOUT) end
> else
>     make_timeout = function() return select(2, pcall(...)) end
> end
> 
> ```

Which is longer and uglier, right? Where is the win?