[Tarantool-patches] [PATCH v1] asan/lsan: cleanup suppression lists

[Tarantool-patches] [PATCH v1] asan/lsan: cleanup suppression lists

[Alexander V. Tikhonov]

Removed asan/lsan suppresions for issues that were not reproduced.
Removed skip condition files for tests that passed testing.

Part of #4360
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/asan-restore
Issue: https://github.com/tarantool/tarantool/issues/4360

 asan/asan.supp             | 10 ---------
 asan/lsan.supp             | 45 ++------------------------------------
 test/app-tap/json.skipcond |  7 ------
 test/unit/guard.skipcond   |  7 ------
 4 files changed, 2 insertions(+), 67 deletions(-)
 delete mode 100644 test/app-tap/json.skipcond
 delete mode 100644 test/unit/guard.skipcond

diff --git a/asan/asan.supp b/asan/asan.supp
index 79c13ec7d..24cb0845a 100644
--- a/asan/asan.supp
+++ b/asan/asan.supp
@@ -5,16 +5,6 @@
 #fun:*
 #src:*
 
-# !test: app-tap/json.test.lua
-# source: third_party/lua-cjson/lua_cjson.c
-fun:json_decode
-
-# test: unit/base64.test.lua
-# source: third_party/base64.c
-fun:base64_decode_block
-# source: test/unit/base64.c
-fun:base64_test
-
 # !test: unit/msgpack.test
 # source: src/lib/msgpuck/test/msgpuck.c
 fun:test_mp_print
diff --git a/asan/lsan.supp b/asan/lsan.supp
index 3273c3baf..1e297d999 100644
--- a/asan/lsan.supp
+++ b/asan/lsan.supp
@@ -44,54 +44,17 @@ leak:tt_bitset_iterator_init
 # source: /lib/x86_64-linux-gnu/libc.so*
 leak:libc.so*
 
-# test: box-tap/schema-mt.test.lua
+# test: box-tap/schema_mt.test.lua
 # source: src/lib/core/coio_task.c
 leak:coio_on_start
 # source: src/lib/salad/mhash.h
 leak:mh_i32ptr_new
 
-# test: replication/misc.test.lua
-# source: src/box/vy_log.c
-leak:vy_recovery_new_f
-# source: src/lib/salad/mhash.h
-leak:mh_i64ptr_new
-
 # test: sql-tap/gh2250-trigger-chain-limit.test.lua
 # source: src/lib/core/exception.cc
 leak:Exception::operator new
 
-# test: sql-tap/trigger9.test.lua
-# source: src/lib/core/fiber.c
-leak:cord_start
-
-# test: sql-tap/tkt-7bbfb7d442.test.lua
-# test: sql-tap/view.test.lua
-# test: sql-tap/with1.test.lua
-# test: sql-tap/with2.test.lua
-# source: src/box/sql/malloc.c
-leak:sql_sized_malloc
-
-# test: swim/errinj.test.lua
-# test: swim/swim.test.lua
-# source: src/lib/swim/swim.c
-leak:swim_member_new
-leak:swim_update_member_payload
-
-# !test: unit/bps_tree.test.lua
-# source: src/lib/salad/bps_tree.h
-leak:bps_tree_test_create_leaf
-leak:bps_tree_test_process_insert_leaf
-
-# !test: unit/heap.test.lua
-# source: test/unit/heap.c
-leak:test_random_delete_workload
-leak:test_delete_last_node
-
-# !test: unit/heap_iterator.test.lua
-# source: src/lib/salad/heap.h
-leak:test_heap_reserve
-
-# !test: unit/swim.test.lua
+# test: unit/swim.test.lua
 # source: src/lib/swim/swim_io.c
 leak:swim_scheduler_set_codec
 
@@ -99,10 +62,6 @@ leak:swim_scheduler_set_codec
 # source: src/lib/core/fiber.h
 leak:fiber_cxx_invoke
 
-# test: vinyl/errinj_ddl.test.lua
-# source: src/box/vy_stmt.c
-leak:vy_stmt_alloc
-
 # test: vinyl/recover.test.lua
 # source: src/lib/core/fiber.c
 leak:cord_costart_thread_func
diff --git a/test/app-tap/json.skipcond b/test/app-tap/json.skipcond
deleted file mode 100644
index e46fd1088..000000000
--- a/test/app-tap/json.skipcond
+++ /dev/null
@@ -1,7 +0,0 @@
-import os
-
-# Disabled at ASAN build due to issue #4360.
-if os.getenv("ASAN") == 'ON':
-    self.skip = 1
-
-# vim: set ft=python:
diff --git a/test/unit/guard.skipcond b/test/unit/guard.skipcond
deleted file mode 100644
index e46fd1088..000000000
--- a/test/unit/guard.skipcond
+++ /dev/null
@@ -1,7 +0,0 @@
-import os
-
-# Disabled at ASAN build due to issue #4360.
-if os.getenv("ASAN") == 'ON':
-    self.skip = 1
-
-# vim: set ft=python:
-- 
2.17.1

Re: [Tarantool-patches] [PATCH v1] asan/lsan: cleanup suppression lists

[Kirill Yukhin]

Hello,

On 20 авг 07:08, Alexander V. Tikhonov wrote:
> Removed asan/lsan suppresions for issues that were not reproduced.
> Removed skip condition files for tests that passed testing.
> 
> Part of #4360
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/asan-restore
> Issue: https://github.com/tarantool/tarantool/issues/4360

I've checked your patch into 1.10, 2.4, 2.5 and master.

--
Regards, Kirill Yukhin