From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 3/3] test: replication/status -- fetch downstream lag field
Date: Sun, 31 Jan 2021 18:46:03 +0100 [thread overview]
Message-ID: <07446e4c-aabf-bbd7-facb-eeeda5472ae7@tarantool.org> (raw)
In-Reply-To: <20210121171753.186891-4-gorcunov@gmail.com>
Thanks for the patch!
> diff --git a/test/replication/status.result b/test/replication/status.result
> index a8c515dbb..e59694730 100644
> --- a/test/replication/status.result
> +++ b/test/replication/status.result
> @@ -186,6 +186,14 @@ test_run:wait_cond(function() \
> ---
> - true
> ...
> +-- once replication vclock is reached there
> +-- should be non infinity downstream lag, set
> +-- it to some sane value but not short since
> +-- there might be network lags on a low level
At least in the tests try to start sentences with a capital
letter and end them with a period. Also for tests related to a
ticket we add 'gh-####: ` to the beginning of the comment.
> +replica.downstream.lag ~= nil and replica.downstream.lag < 60
> +---
> +- true
> +...
next prev parent reply other threads:[~2021-01-31 17:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 17:17 [Tarantool-patches] [PATCH 0/3] box/info: report replication.X.downstream.lag Cyrill Gorcunov via Tarantool-patches
2021-01-21 17:17 ` [Tarantool-patches] [PATCH 1/3] xrow: encode timestamp into vclock message Cyrill Gorcunov via Tarantool-patches
2021-01-31 17:43 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-21 17:17 ` [Tarantool-patches] [PATCH 2/3] box/info: report replication.X.downstream.lag value Cyrill Gorcunov via Tarantool-patches
2021-01-27 11:56 ` Serge Petrenko via Tarantool-patches
2021-01-27 12:12 ` Cyrill Gorcunov via Tarantool-patches
2021-01-27 14:04 ` Serge Petrenko via Tarantool-patches
2021-01-27 14:38 ` Cyrill Gorcunov via Tarantool-patches
2021-01-27 14:44 ` Serge Petrenko via Tarantool-patches
2021-01-31 17:45 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-21 17:17 ` [Tarantool-patches] [PATCH 3/3] test: replication/status -- fetch downstream lag field Cyrill Gorcunov via Tarantool-patches
2021-01-31 17:46 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-01-21 17:17 ` Cyrill Gorcunov via Tarantool-patches
2021-01-21 17:23 ` Cyrill Gorcunov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07446e4c-aabf-bbd7-facb-eeeda5472ae7@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 3/3] test: replication/status -- fetch downstream lag field' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox