From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4 4/6] sql: use parser's region of "index" array
Date: Thu, 17 Sep 2020 16:53:47 +0200 [thread overview]
Message-ID: <06ae460c-b078-cbbb-14b5-7970ba669d40@tarantool.org> (raw)
In-Reply-To: <20200911215115.6622-5-roman.habibov@tarantool.org>
Thanks for the patch!
On 11.09.2020 23:51, Roman Khabibov wrote:
> Allocate memory for the "index" array of ephemeral space on the
> parser's region instead of a heap as it was before. Fixed a memory
> leak that realloc() generated.
You need to provide more info why it can't be stored on the heap,
and why free() can't be simply called somewhere.
next prev parent reply other threads:[~2020-09-17 14:53 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 21:51 [Tarantool-patches] [PATCH v4 0/6] Support column addition Roman Khabibov
2020-09-11 21:51 ` [Tarantool-patches] [PATCH v4 1/6] sql: rename TK_COLUMN to TK_COLUMN_NAME Roman Khabibov
2020-09-16 13:17 ` Nikita Pettik
2020-09-28 23:29 ` Roman Khabibov
2020-09-11 21:51 ` [Tarantool-patches] [PATCH v4 2/6] sql: refactor create_table_def and parse Roman Khabibov
2020-09-16 13:27 ` Nikita Pettik
2020-09-17 14:43 ` Vladislav Shpilevoy
2020-09-18 12:31 ` Nikita Pettik
2020-09-18 13:21 ` Roman Khabibov
2020-09-28 23:29 ` Roman Khabibov
2020-09-17 14:43 ` Vladislav Shpilevoy
2020-10-02 22:08 ` Vladislav Shpilevoy
2020-10-03 21:37 ` Roman Khabibov
2020-10-04 13:45 ` Vladislav Shpilevoy
2020-10-04 21:44 ` Roman Khabibov
2020-10-05 21:22 ` Vladislav Shpilevoy
2020-10-07 13:53 ` Roman Khabibov
2020-10-07 22:35 ` Vladislav Shpilevoy
2020-10-08 10:32 ` Roman Khabibov
2020-09-17 15:16 ` Vladislav Shpilevoy
2020-10-02 22:08 ` Vladislav Shpilevoy
2020-09-11 21:51 ` [Tarantool-patches] [PATCH v4 3/6] schema: add box_space_field_MAX Roman Khabibov
2020-09-11 21:51 ` [Tarantool-patches] [PATCH v4 4/6] sql: use parser's region of "index" array Roman Khabibov
2020-09-16 13:30 ` Nikita Pettik
2020-09-28 23:29 ` Roman Khabibov
2020-09-17 14:53 ` Vladislav Shpilevoy [this message]
2020-09-23 14:25 ` Roman Khabibov
2020-09-24 21:30 ` Vladislav Shpilevoy
2020-10-05 21:22 ` Vladislav Shpilevoy
2020-10-07 13:53 ` Roman Khabibov
2020-09-11 21:51 ` [Tarantool-patches] [PATCH v4 5/6] box: disallow to modify format of a view Roman Khabibov
2020-09-16 13:37 ` Nikita Pettik
2020-09-22 15:59 ` Roman Khabibov
2020-09-17 15:01 ` Vladislav Shpilevoy
2020-09-22 15:59 ` Roman Khabibov
2020-09-11 21:51 ` [Tarantool-patches] [PATCH v4 6/6] sql: support column addition Roman Khabibov
2020-09-16 20:18 ` Nikita Pettik
2020-09-17 15:19 ` Vladislav Shpilevoy
2020-09-18 12:59 ` Nikita Pettik
2020-09-28 23:28 ` Roman Khabibov
2020-10-02 22:08 ` Vladislav Shpilevoy
2020-10-03 21:37 ` Roman Khabibov
2020-09-17 15:45 ` Vladislav Shpilevoy
2020-10-04 13:45 ` Vladislav Shpilevoy
2020-10-04 21:44 ` Roman Khabibov
2020-09-11 22:00 ` [Tarantool-patches] [PATCH v4 0/6] Support " Roman Khabibov
2020-10-08 22:07 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06ae460c-b078-cbbb-14b5-7970ba669d40@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 4/6] sql: use parser'\''s region of "index" array' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox