From: Imeev Mergen <imeevma@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>, v.shpilevoy@tarantool.org
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] netbox: fix memleak in lbox_tuple_format_new()
Date: Thu, 31 Oct 2019 19:43:37 +0300 [thread overview]
Message-ID: <05dc9a5b-f3c8-37f9-3dd7-63cfc966bf11@tarantool.org> (raw)
In-Reply-To: <20191031152306.GD2636@atlas>
On 10/31/19 6:23 PM, Konstantin Osipov wrote:
> * imeevma@tarantool.org <imeevma@tarantool.org> [19/10/30 14:03]:
>> Memleak appeared due to the fact that when creating a dictionary
>> its reference count is 1 from the beginning. Later, when the
>> dictionary is used to create tuple_format, its reference counter
>> increased by 1 and it became equal to 2. After removing
>> tuple_format, the reference counter for dict decreased by one, so
>> it became equal to 1. Since ref counter is not equal to 0, dict
>> not deleted, causing a memory leak.
>>
>> Closes #4588
> I wonder if you could come up with a test case? Is memory used by
> dict accounted in any stats?
>
I did not find anything in box, and I did not see anything about
the statistics in the tuple_dictionary_new() function. Doesn't
look like we accounting this. At the moment, I can’t come up with
a test.
You think we should add this in stats?
next prev parent reply other threads:[~2019-10-31 16:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 10:58 imeevma
2019-10-30 22:13 ` Vladislav Shpilevoy
2019-10-31 9:33 ` [Tarantool-patches] [tarantool-patches] " Mergen Imeev
2019-10-31 15:23 ` [Tarantool-patches] " Konstantin Osipov
2019-10-31 16:43 ` Imeev Mergen [this message]
2019-11-02 16:26 ` Vladislav Shpilevoy
2019-11-05 10:38 ` [Tarantool-patches] [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05dc9a5b-f3c8-37f9-3dd7-63cfc966bf11@tarantool.org \
--to=imeevma@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 1/1] netbox: fix memleak in lbox_tuple_format_new()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox