From: sergepetrenko <sergepetrenko@tarantool.org> To: alexander.turenko@tarantool.org, v.shpilevoy@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH 2/2] wal: panic when trying to write a record with a broken lsn Date: Thu, 13 Feb 2020 02:51:01 +0300 [thread overview] Message-ID: <05d98ad17bd55b1437511c7ed57ee82a9a1625f9.1581551227.git.sergepetrenko@tarantool.org> (raw) In-Reply-To: <cover.1581551227.git.sergepetrenko@tarantool.org> There is an assertion in vclock_follow `lsn > prev_lsn`, which doesn't fire in release builds, of course. So we better panic on an attemt to write a record with a duplicate or otherwise broken lsn. Follow-up #4739 --- src/box/wal.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/box/wal.c b/src/box/wal.c index 0ae66ff32..3d4317f34 100644 --- a/src/box/wal.c +++ b/src/box/wal.c @@ -951,9 +951,18 @@ wal_assign_lsn(struct vclock *vclock_diff, struct vclock *base, (*row)->tsn = tsn; (*row)->is_commit = row == end - 1; } else { - vclock_follow(vclock_diff, (*row)->replica_id, - (*row)->lsn - vclock_get(base, - (*row)->replica_id)); + int64_t diff = (*row)->lsn - vclock_get(base, (*row)->replica_id); + if (diff <= vclock_get(vclock_diff, + (*row)->replica_id)) { + panic("Attempt to write a broken LSN to WAL:" + " replica id: %d, committed lsn: %d," + " new lsn %d", (*row)->replica_id, + vclock_get(base, (*row)->replica_id) + + vclock_get(vclock_diff, + (*row)->replica_id), + (*row)->lsn); + } + vclock_follow(vclock_diff, (*row)->replica_id, diff); } } } -- 2.20.1 (Apple Git-117)
next prev parent reply other threads:[~2020-02-12 23:51 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-12 23:50 [Tarantool-patches] [PATCH 0/2] replication: fix applying of rows originating from local instance sergepetrenko 2020-02-12 23:51 ` [Tarantool-patches] [PATCH 1/2] replication: correctly check for rows to skip in applier sergepetrenko 2020-02-13 6:47 ` Konstantin Osipov 2020-02-13 6:58 ` Konstantin Osipov 2020-02-13 22:03 ` Sergey Petrenko 2020-02-13 22:10 ` Sergey Petrenko 2020-02-12 23:51 ` sergepetrenko [this message] 2020-02-13 6:48 ` [Tarantool-patches] [PATCH 2/2] wal: panic when trying to write a record with a broken lsn Konstantin Osipov 2020-02-13 22:05 ` Sergey Petrenko 2020-02-14 7:26 ` Konstantin Osipov 2020-02-13 6:48 ` [Tarantool-patches] [PATCH 0/2] replication: fix applying of rows originating from local instance Konstantin Osipov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=05d98ad17bd55b1437511c7ed57ee82a9a1625f9.1581551227.git.sergepetrenko@tarantool.org \ --to=sergepetrenko@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 2/2] wal: panic when trying to write a record with a broken lsn' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox