Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>,
	Oleg Piskunov <o.piskunov@tarantool.org>,
	Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] test: fix box/push.test.lua for ASAN
Date: Thu, 28 May 2020 00:21:10 +0200	[thread overview]
Message-ID: <05b4faaa-0fc3-2cb4-cdba-c04d43c462e3@tarantool.org> (raw)
In-Reply-To: <30d78005ea9ea576b7ba4c3065c2c60ab91a9408.1590592525.git.avtikhon@tarantool.org>

Hi! Thanks for the patch!

I sent an alternative fix in a new email thread. Check it out.

> diff --git a/asan/asan.supp b/asan/asan.supp
> index 79c13ec7d..b806873a5 100644
> --- a/asan/asan.supp
> +++ b/asan/asan.supp
> @@ -9,6 +9,10 @@
>  # source: third_party/lua-cjson/lua_cjson.c
>  fun:json_decode
>  
> +# test: box/push.test.lua
> +# source: src/lib/msgpuck/hints.c:39:20
> +src:*src/lib/msgpuck/hints.c

Why did you use '*' in the beginning though it is
not used on other 'src:' lines?

      reply	other threads:[~2020-05-27 22:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 15:20 Alexander V. Tikhonov
2020-05-27 22:21 ` Vladislav Shpilevoy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05b4faaa-0fc3-2cb4-cdba-c04d43c462e3@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=o.piskunov@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1] test: fix box/push.test.lua for ASAN' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox