From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: parameter binding for box.execute()
Date: Mon, 1 Apr 2019 16:44:03 +0300 [thread overview]
Message-ID: <05765e13-bc1e-e52b-e1c4-c749c4518e6c@tarantool.org> (raw)
In-Reply-To: <20190401130544.GA2628@chai>
Separate patch would ruin the git history. I would
rather fix this and box.sql.execute removal patchsets
to keep the history clean.
On 01/04/2019 16:05, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/04/01 11:45]:
>>
>>
>> On 01/04/2019 08:21, Konstantin Osipov wrote:
>>> * imeevma@tarantool.org <imeevma@tarantool.org> [19/03/30 16:50]:
>>>> This patch defines parameters binding for SQL statements executed
>>>> through box.execute().
>>>
>>> Could the dependency on lua_* be moved into src/box/lua/ or that
>>> would be difficult to do?
>>
>> It requires exposure of struct sql_bind into the header file, and
>> include "execute.h" into one of box/lua files. If you insist, we
>> can do that. Should we?
>
> Yes, in a separate patch.
>
>
> --
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
>
prev parent reply other threads:[~2019-04-01 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 12:01 [tarantool-patches] " imeevma
2019-03-30 17:07 ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-30 17:08 ` Vladislav Shpilevoy
2019-04-01 5:21 ` Konstantin Osipov
2019-04-01 8:44 ` Vladislav Shpilevoy
2019-04-01 10:27 ` Vladislav Shpilevoy
2019-04-01 13:05 ` Konstantin Osipov
2019-04-01 13:44 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05765e13-bc1e-e52b-e1c4-c749c4518e6c@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: parameter binding for box.execute()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox