From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: disallow division by zero
Date: Fri, 13 Jul 2018 14:49:28 +0300 [thread overview]
Message-ID: <04f25851-5856-51fb-9d45-2af6561872a8@tarantool.org> (raw)
In-Reply-To: <50125917-283f-11a9-5849-5026efd17cef@tarantool.org>
Hi! Thank you for review.
> 1. Typo.
Fixed.
> 2. Garbage comment.Dropped. It wasn't mine.
> 3. Such huge test for division by zero is overkill. Please, fix the test to
> avoid division by zero. Obviously it was not about divisions.
Ok, I've changed one sign to fix this test case:
return test:execsql "SELECT f+case when 17-t1.f in (select ~count(distinct (abs((abs(c)/abs(c)))/abs((abs(11)/abs(+case .....
return test:execsql "SELECT f+case when 17-t1.f in (select ~count(distinct (abs((abs(c)/abs(c)))/abs((abs(11)*abs(+case .....
Test result didn't change.
next prev parent reply other threads:[~2018-07-13 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 11:16 [tarantool-patches] " Kirill Shcherbatov
2018-07-13 9:50 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-13 11:49 ` Kirill Shcherbatov [this message]
2018-07-16 10:31 ` Vladislav Shpilevoy
2018-07-16 10:59 ` n.pettik
2018-07-16 14:45 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04f25851-5856-51fb-9d45-2af6561872a8@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: disallow division by zero' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox