Re: [Tarantool-patches] [PATCH v2 0/2] sql: introduce UUID

[Timur Safin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Thanks for these additions since previous version I've seen - it's now much
closer to the "Consistent SQL/Lua types" RFC we have agreed upon before. 

LGTM to whole patchset (with few minor, not blocking complains here and there)

Timur

: -----Original Message-----
: From: imeevma@tarantool.org <imeevma@tarantool.org>
: Sent: Wednesday, June 2, 2021 11:03 AM
: To: tsafin@tarantool.org
: Cc: tarantool-patches@dev.tarantool.org
: Subject: [PATCH v2 0/2] sql: introduce UUID
: 
: This patch-set introduces UUID to SQL. After this patch-set UUID field type
: will
: be available in SQL and UUID values can be generated using UUID() function.
: 
: https://github.com/tarantool/tarantool/issues/5886
: https://github.com/tarantool/tarantool/tree/imeevma/gh-5886-introduce-uuid-
: type-in-sql
: 
: Changes in v2:
:  - Added SQL built-in function uuid().
: 
: Mergen Imeev (2):
:   sql: introduce UUID field type
:   sql: introduce SQL built-in function UUID()
: 
:  .../unreleased/introduce-uuid-to-sql.md       |    3 +
:  extra/mkkeywordhash.c                         |    1 +
:  src/box/bootstrap.snap                        |  Bin 5991 -> 6016 bytes
:  src/box/lua/upgrade.lua                       |   19 +
:  src/box/sql/func.c                            |   69 +-
:  src/box/sql/mem.c                             |  203 ++-
:  src/box/sql/mem.h                             |   29 +-
:  src/box/sql/parse.y                           |    3 +-
:  src/box/sql/vdbe.c                            |   15 +-
:  test/box-py/bootstrap.result                  |    3 +-
:  test/box/access.result                        |    2 +-
:  test/box/access.test.lua                      |    2 +-
:  test/box/access_bin.result                    |    2 +-
:  test/box/access_bin.test.lua                  |    2 +-
:  test/box/access_sysview.result                |    8 +-
:  test/box/function1.result                     |    6 +-
:  test/sql-tap/CMakeLists.txt                   |    1 +
:  .../gh-5913-segfault-on-select-uuid.test.lua  |   42 +-
:  .../sql-tap/gh-6024-funcs-return-bin.test.lua |    8 +-
:  test/sql-tap/sql_uuid.c                       |   46 +
:  test/sql-tap/uuid.test.lua                    | 1344 +++++++++++++++++
:  test/wal_off/func_max.result                  |    8 +-
:  22 files changed, 1731 insertions(+), 85 deletions(-)
:  create mode 100644 changelogs/unreleased/introduce-uuid-to-sql.md
:  create mode 100644 test/sql-tap/sql_uuid.c
:  create mode 100755 test/sql-tap/uuid.test.lua
: 
: --
: 2.25.1