Re: [Tarantool-patches] [PATCH 2/4] sql: refactor sqlVdbeMemNumerify()

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Hi! Thanks for the fixes!

I've pushed my review fixes on top of this commit. See it in the
end of the email, and on the branch. I aligned the comment by
66 symbols, and changed '@mem' to '@a mem' in a second place.

Talking of your questions - why do we use @a? I think just because
it was needed to choose something and @a was chosen. From what I
remember, doxygen does not have a special command for mentioning
function parameters inside function's description. So there was no
a standard way.

================================================================================

commit bde8e58b05c5e4d3c650eea10e5905ce228b943d
Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Date:   Tue Feb 11 23:07:36 2020 +0100

    Review fixes

diff --git a/src/box/sql/vdbeInt.h b/src/box/sql/vdbeInt.h
index 9ecf7a486..38305ce1d 100644
--- a/src/box/sql/vdbeInt.h
+++ b/src/box/sql/vdbeInt.h
@@ -535,11 +535,12 @@ int mem_apply_integer_type(Mem *);
 int sqlVdbeMemRealify(Mem *);
 
 /**
- * Convert @a mem to NUMBER type, so that after conversion it has one
- * of types MEM_Real, MEM_Int or MEM_UInt. If conversion is not possible,
- * function returns -1.
+ * Convert @a mem to NUMBER type, so that after conversion it has
+ * one of types MEM_Real, MEM_Int or MEM_UInt. If conversion is
+ * not possible, function returns -1.
  *
- * Beware - this function changes value and type of @mem argument
+ * Beware - this function changes value and type of @a mem
+ * argument.
  */
 int
 vdbe_mem_numerify(struct Mem *mem);