From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v12 3/8] module_cache: improve naming
Date: Sun, 24 Jan 2021 17:27:12 +0100 [thread overview]
Message-ID: <03fe6138-05d8-a88d-eae5-05d060b54f7a@tarantool.org> (raw)
In-Reply-To: <20210118203556.281700-4-gorcunov@gmail.com>
Thanks for the patch!
Very dubious commit. To me the old and new names look the same.
'func_name' was even better than 'func_name_desc'. At least
because it was shorter, and 'desc' does not add any more meaning.
On 18.01.2021 21:35, Cyrill Gorcunov via Tarantool-patches wrote:
> - rename func_name to func_name_desc because
> it is not just a name but rather a name descriptor
> which includes symbol address
I don't see any address in it. Only name tokens.
> - rename func_split_name to parse_func_name because
> the action of splitting name to parts is not what
> the function about, the function parses specification
> to fetch a descriptor
>
> Part-of #4642
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
next prev parent reply other threads:[~2021-01-24 16:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 20:35 [Tarantool-patches] [PATCH v12 0/8] box: implement cmod Lua module Cyrill Gorcunov via Tarantool-patches
2021-01-18 20:35 ` [Tarantool-patches] [PATCH v12 1/8] box/func: factor out c function entry structure Cyrill Gorcunov via Tarantool-patches
2021-01-18 20:35 ` [Tarantool-patches] [PATCH v12 2/8] module_cache: move module handling into own subsystem Cyrill Gorcunov via Tarantool-patches
2021-01-24 16:26 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-25 8:52 ` Cyrill Gorcunov via Tarantool-patches
2021-01-18 20:35 ` [Tarantool-patches] [PATCH v12 3/8] module_cache: improve naming Cyrill Gorcunov via Tarantool-patches
2021-01-24 16:27 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-01-24 22:32 ` Cyrill Gorcunov via Tarantool-patches
2021-01-30 18:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-01 11:41 ` Cyrill Gorcunov via Tarantool-patches
2021-01-18 20:35 ` [Tarantool-patches] [PATCH v12 4/8] module_cache: direct update a cache value on reload Cyrill Gorcunov via Tarantool-patches
2021-01-19 12:46 ` Cyrill Gorcunov via Tarantool-patches
2021-01-24 16:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-24 22:26 ` Cyrill Gorcunov via Tarantool-patches
2021-01-18 20:35 ` [Tarantool-patches] [PATCH v12 5/8] module_cache: rename calls to ref in module structure Cyrill Gorcunov via Tarantool-patches
2021-01-24 16:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-25 10:29 ` Cyrill Gorcunov via Tarantool-patches
2021-01-18 20:35 ` [Tarantool-patches] [PATCH v12 6/8] module_cache: provide helpers to load and unload modules Cyrill Gorcunov via Tarantool-patches
2021-01-24 16:28 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-18 20:35 ` [Tarantool-patches] [PATCH v12 7/8] box/cmod: implement cmod Lua module Cyrill Gorcunov via Tarantool-patches
2021-01-24 16:28 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-25 16:50 ` Cyrill Gorcunov via Tarantool-patches
2021-01-30 18:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-18 20:35 ` [Tarantool-patches] [PATCH v12 8/8] test: box/cfunc -- add cmod test Cyrill Gorcunov via Tarantool-patches
2021-01-24 16:28 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-24 16:26 ` [Tarantool-patches] [PATCH v12 0/8] box: implement cmod Lua module Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03fe6138-05d8-a88d-eae5-05d060b54f7a@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v12 3/8] module_cache: improve naming' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox