From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0EF408205E; Sun, 24 Jan 2021 19:27:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0EF408205E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611505655; bh=CFky8umqhge3WqVbRZaBF/BeF98gK7PT30lTqNSojQ4=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=IZ9PcYjmGWAObGCFwMOb41QYLJ9NBZbSk6k4EWY2yUFQdBRSt4arcHaQSrhUHzf95 1zV6nzi98hWsvh8kVMyLov2hJqgfu2fgWcQTB7GbvOLstv6XoFBeOl4v0mxIKUeGML 0V5bN7+kRyjZlSGdwe3c5s7+AXG2YYuVSktBvG7Q= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 938338205E for ; Sun, 24 Jan 2021 19:27:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 938338205E Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1l3iEL-0002fG-4u; Sun, 24 Jan 2021 19:27:13 +0300 To: Cyrill Gorcunov , tml References: <20210118203556.281700-1-gorcunov@gmail.com> <20210118203556.281700-4-gorcunov@gmail.com> Message-ID: <03fe6138-05d8-a88d-eae5-05d060b54f7a@tarantool.org> Date: Sun, 24 Jan 2021 17:27:12 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210118203556.281700-4-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9F0E84CC1954AA438CF139A4DF54DC2E88E2FE7C97C65DF6000894C459B0CD1B9977421BB8FF96D14D6D5816A42478B9EE677AB1C9F20D3C873C1DF025D8865E1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7370F4F695FFFC24BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063764345650F0BBEB0B8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC520051DBA2F12A10BEA99F007E1DB2EB4D4744D48CCF4F80389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C078FCF50C7EAF9C588941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B68424CA1AAF98A6958941B15DA834481F9449624AB7ADAF3735872C767BF85DA29E625A9149C048EE0A3850AC1BE2E735F1C9CF18C8EB22694AD6D5ED66289B524E70A05D1297E1BB35872C767BF85DA227C277FBC8AE2E8BAEFF4136F5E2B48575ECD9A6C639B01B4E70A05D1297E1BBC6867C52282FAC85D9B7C4F32B44FF57E8FBB06288C1946000306258E7E6ABB4E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A55EF1FBD9129EA63A8356EC0D4CB3C78FF3E84C76F55F0677D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347215713CF3EEE9D1A98DE4789D4A5B67CE34CA250EBDF5BCE1F088082C1042541EA4BBCCFE4DFC4D1D7E09C32AA3244C48A6F6162E494C165FDA5DB70AE686CF8A6D4CC6FBFAC251729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojEcKN7r9rK/2A4itUpli/gQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382215BA52F81CBAF13487A69CC92A009B103841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v12 3/8] module_cache: improve naming X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! Very dubious commit. To me the old and new names look the same. 'func_name' was even better than 'func_name_desc'. At least because it was shorter, and 'desc' does not add any more meaning. On 18.01.2021 21:35, Cyrill Gorcunov via Tarantool-patches wrote: > - rename func_name to func_name_desc because > it is not just a name but rather a name descriptor > which includes symbol address I don't see any address in it. Only name tokens. > - rename func_split_name to parse_func_name because > the action of splitting name to parts is not what > the function about, the function parses specification > to fetch a descriptor > > Part-of #4642 > > Signed-off-by: Cyrill Gorcunov > ---