From: "Timur Safin" <tsafin@tarantool.org>
To: 'Vladislav Shpilevoy' <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org, alyapunov@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 00/11] Enable miscelaneous sanitations
Date: Sat, 6 Jun 2020 01:09:41 +0300 [thread overview]
Message-ID: <03bb01d63b86$035fe140$0a1fa3c0$@tarantool.org> (raw)
In-Reply-To: <cover.1591313754.git.v.shpilevoy@tarantool.org>
I've looked into all patches of this patchset, and they look
very much ok (especially the Guava story).
Have no energy to send LGTM to each part, thus sending it for
the whole set:
LGTM
Timur
: From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
: Subject: [PATCH 00/11] Enable miscelaneous sanitations
:
: The patchset is a second part of the undefined behaviour fixes. It
: is based on the UB alignment patchset, and enables all the other
: UB checks except a few last ones, described in the first commit.
:
: Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4609-
: sanitize-misc-full-ci
: Issue: https://github.com/tarantool/tarantool/issues/4609
:
: Aleksandr Lyapunov (1):
: salad: fix UB pointer arithmetics in bps_tree
:
: Vladislav Shpilevoy (10):
: cmake: enable misc types of UB detection in clang
: util: introduce double_compare_nint64()
: test: avoid usleep() usage for error injections
: vinyl: fix 0 division in case of canceled dump
: xrow: don't cast double to float unconditionally
: swim: fix zero division
: test: fix signed integer overflow in vclock test
: digest: eliminate UBs from guava()
: sql: fix usage of not initialized index_stat
: sql: fix mem_apply_type double type truncation
:
: cmake/compiler.cmake | 16 ++++++++++++++-
: src/box/sql/vdbe.c | 18 +++++++++++------
: src/box/sql/vdbeaux.c | 16 +++++++--------
: src/box/sql/where.c | 4 ++--
: src/box/tuple_compare.cc | 9 ++-------
: src/box/vy_regulator.c | 10 ++++++----
: src/box/vy_run.c | 2 +-
: src/box/vy_scheduler.c | 2 +-
: src/box/xrow_update_field.c | 19 +++++++++---------
: src/lib/core/util.c | 39 ++++++++++++++++++++++++++++++++++++-
: src/lib/salad/bps_tree.h | 14 ++++++-------
: src/lib/salad/guava.c | 18 ++++++++++-------
: src/lib/salad/guava.h | 2 +-
: src/lib/swim/swim.c | 10 +++++-----
: src/lua/digest.lua | 2 +-
: src/trivia/util.h | 29 +++++++++++++++++++++++++++
: test/app/digest.result | 2 +-
: test/box/update.result | 2 +-
: test/box/update.test.lua | 2 +-
: test/unit/vclock.cc | 28 +++++++++++++-------------
: test/unit/vclock.result | 2 +-
: 21 files changed, 167 insertions(+), 79 deletions(-)
:
: --
: 2.21.1 (Apple Git-122.3)
next prev parent reply other threads:[~2020-06-05 22:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 23:43 Vladislav Shpilevoy
2020-06-04 23:43 ` [Tarantool-patches] [PATCH 01/11] cmake: enable misc types of UB detection in clang Vladislav Shpilevoy
2020-06-04 23:43 ` [Tarantool-patches] [PATCH 10/11] sql: fix usage of not initialized index_stat Vladislav Shpilevoy
2020-06-04 23:43 ` [Tarantool-patches] [PATCH 11/11] sql: fix mem_apply_type double type truncation Vladislav Shpilevoy
2020-06-04 23:43 ` [Tarantool-patches] [PATCH 02/11] util: introduce double_compare_nint64() Vladislav Shpilevoy
2020-06-04 23:43 ` [Tarantool-patches] [PATCH 03/11] test: avoid usleep() usage for error injections Vladislav Shpilevoy
2020-06-04 23:43 ` [Tarantool-patches] [PATCH 04/11] vinyl: fix 0 division in case of canceled dump Vladislav Shpilevoy
2020-06-04 23:43 ` [Tarantool-patches] [PATCH 05/11] xrow: don't cast double to float unconditionally Vladislav Shpilevoy
2020-06-04 23:43 ` [Tarantool-patches] [PATCH 06/11] swim: fix zero division Vladislav Shpilevoy
2020-06-04 23:43 ` [Tarantool-patches] [PATCH 07/11] test: fix signed integer overflow in vclock test Vladislav Shpilevoy
2020-06-04 23:43 ` [Tarantool-patches] [PATCH 08/11] digest: eliminate UBs from guava() Vladislav Shpilevoy
2020-06-04 23:43 ` [Tarantool-patches] [PATCH 09/11] salad: fix UB pointer arithmetics in bps_tree Vladislav Shpilevoy
2020-06-05 22:09 ` Timur Safin [this message]
2020-06-09 8:19 ` [Tarantool-patches] [PATCH 00/11] Enable miscelaneous sanitations Cyrill Gorcunov
2020-06-09 8:28 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='03bb01d63b86$035fe140$0a1fa3c0$@tarantool.org' \
--to=tsafin@tarantool.org \
--cc=alyapunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 00/11] Enable miscelaneous sanitations' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox