From: imeevma@tarantool.org To: v.shpilevoy@tarantool.org Cc: avtikhon@tarantool.org, tarantool-patches@freelists.org Subject: [tarantool-patches] [PATCH v1 1/1] box: do not check state in case of reconnect Date: Thu, 11 Jul 2019 17:12:35 +0300 [thread overview] Message-ID: <03b9fb9b57353762ee6b9c8fb12fc3dd4c177eb7.1562854125.git.imeevma@gmail.com> (raw) Test box/net.box.test.lua checks state of the connection in case of an error. It should be 'error_reconnect'. But, in cases where testing was performed on a slow computer or in the case of a very large load, it is possible that the connection status may change from the 'error_reconnect' state to another state. This led to the failure of the test. Since this check is not the main purpose of the test, it is better to simply delete the check. Closes #4335 --- https://github.com/tarantool/tarantool/issues/4335 https://github.com/tarantool/tarantool/tree/imeevma/gh-4335-reconnect-state-error test/box/net.box.result | 4 ---- test/box/net.box.test.lua | 1 - 2 files changed, 5 deletions(-) diff --git a/test/box/net.box.result b/test/box/net.box.result index a18546d..92b6a2c 100644 --- a/test/box/net.box.result +++ b/test/box/net.box.result @@ -2818,10 +2818,6 @@ c.space.test:delete{1} _ = c._transport.perform_request(nil, nil, false, 'inject', nil, nil, nil, '\x80') --- ... -c.state ---- -- error_reconnect -... while not c:is_connected() do fiber.sleep(0.01) end --- ... diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua index 07558a0..e213d9a 100644 --- a/test/box/net.box.test.lua +++ b/test/box/net.box.test.lua @@ -1156,7 +1156,6 @@ c.space.test:delete{1} -- Break a connection to test reconnect_after. -- _ = c._transport.perform_request(nil, nil, false, 'inject', nil, nil, nil, '\x80') -c.state while not c:is_connected() do fiber.sleep(0.01) end c:ping() -- 2.7.4
next reply other threads:[~2019-07-11 14:12 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-11 14:12 imeevma [this message] 2019-07-11 21:35 ` [tarantool-patches] " Vladislav Shpilevoy 2019-07-12 9:08 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=03b9fb9b57353762ee6b9c8fb12fc3dd4c177eb7.1562854125.git.imeevma@gmail.com \ --to=imeevma@tarantool.org \ --cc=avtikhon@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [tarantool-patches] [PATCH v1 1/1] box: do not check state in case of reconnect' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox